From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48698) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4yFC-0008Os-Mq for qemu-devel@nongnu.org; Tue, 16 Jun 2015 17:18:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z4yFB-0006Bn-Pd for qemu-devel@nongnu.org; Tue, 16 Jun 2015 17:18:06 -0400 Date: Tue, 16 Jun 2015 23:17:52 +0200 From: "Michael S. Tsirkin" Message-ID: <20150616231735-mutt-send-email-mst@redhat.com> References: <1434458200-23440-1-git-send-email-mst@redhat.com> <1434458200-23440-4-git-send-email-mst@redhat.com> <55803BE0.7000206@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55803BE0.7000206@redhat.com> Subject: Re: [Qemu-devel] [PATCH RFC 3/3] block/nfs: switch to error_init_local List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, qemu-block@nongnu.org, Jeff Cody , Peter Lieven , qemu-devel@nongnu.org, armbru@redhat.com, dgilbert@redhat.com On Tue, Jun 16, 2015 at 09:08:16AM -0600, Eric Blake wrote: > On 06/16/2015 06:53 AM, Michael S. Tsirkin wrote: > > We probably should just switch everyone, this is > > just to demonstrate the API usage. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > block/nfs.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > And indeed this is the reason things are still at RFC level. I like the > idea. It doesn't change anything for a bug-free program, but where we > DO have a bug, we now get a stacktrace that aborts as soon as possible > rather than delaying to the propagation point and losing some information. > > > > > diff --git a/block/nfs.c b/block/nfs.c > > index ca9e24e..de4b8c3 100644 > > --- a/block/nfs.c > > +++ b/block/nfs.c > > @@ -385,7 +385,7 @@ static int nfs_file_open(BlockDriverState *bs, QDict *options, int flags, > > NFSClient *client = bs->opaque; > > int64_t ret; > > QemuOpts *opts; > > - Error *local_err = NULL; > > + Error *local_err = error_init_local(errp); > > Should be a fairly mechanical patch to catch all the spots; although > there are multiple spellings (not all callers name it local_err). I'll try to write an spatch to do this. > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org >