* Re: [Qemu-devel] [Qemu-block] NVMe volatile write cache fixes
[not found] <1434016899-18643-1-git-send-email-hch@lst.de>
@ 2015-06-11 12:26 ` Eric Blake
2015-06-17 11:59 ` Christoph Hellwig
2015-07-08 10:05 ` Kevin Wolf
1 sibling, 1 reply; 5+ messages in thread
From: Eric Blake @ 2015-06-11 12:26 UTC (permalink / raw)
To: Christoph Hellwig, qemu-block
Cc: Keith Busch, kwolf@redhat.com, qemu-devel@nongnu.org
[-- Attachment #1: Type: text/plain, Size: 692 bytes --]
On 06/11/2015 04:01 AM, Christoph Hellwig wrote:
> The first patch ensures that flush actually flushes data so that
> data integrity is preserved, the second fixe up WCE reporting.
>
Cover letter is missing a diffstat and also a 0/2 designation, which
makes it harder to see up front what it touches (git
format-patch/send-email --cover-letter is your friend). Also, you
forgot to cc: the maintainer and the primary qemu-devel list (qemu-devel
should be included in ALL patches, and scripts/get_maintainer.pl will
help you learn maintainers). I've added them in cc.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [Qemu-block] NVMe volatile write cache fixes
2015-06-11 12:26 ` [Qemu-devel] [Qemu-block] NVMe volatile write cache fixes Eric Blake
@ 2015-06-17 11:59 ` Christoph Hellwig
2015-06-17 12:24 ` Kevin Wolf
0 siblings, 1 reply; 5+ messages in thread
From: Christoph Hellwig @ 2015-06-17 11:59 UTC (permalink / raw)
To: Eric Blake
Cc: Keith Busch, kwolf@redhat.com, qemu-devel@nongnu.org, qemu-block
Thank Eric.
Kevin,
do you want me to resend the series with these cover letter/cc fixes or
is it okay this time?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [Qemu-block] NVMe volatile write cache fixes
2015-06-17 11:59 ` Christoph Hellwig
@ 2015-06-17 12:24 ` Kevin Wolf
2015-07-04 4:58 ` Christoph Hellwig
0 siblings, 1 reply; 5+ messages in thread
From: Kevin Wolf @ 2015-06-17 12:24 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Keith Busch, qemu-devel@nongnu.org, qemu-block
Am 17.06.2015 um 13:59 hat Christoph Hellwig geschrieben:
> Thank Eric.
>
> Kevin,
>
> do you want me to resend the series with these cover letter/cc fixes or
> is it okay this time?
It's not worth a respin. I'm just waiting for an Acked-by (or whatever
other outcome of a review) from Keith before I merge this.
Kevin
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [Qemu-block] NVMe volatile write cache fixes
2015-06-17 12:24 ` Kevin Wolf
@ 2015-07-04 4:58 ` Christoph Hellwig
0 siblings, 0 replies; 5+ messages in thread
From: Christoph Hellwig @ 2015-07-04 4:58 UTC (permalink / raw)
To: Kevin Wolf
Cc: Keith Busch, Christoph Hellwig, qemu-block, qemu-devel@nongnu.org
On Wed, Jun 17, 2015 at 02:24:06PM +0200, Kevin Wolf wrote:
> Am 17.06.2015 um 13:59 hat Christoph Hellwig geschrieben:
> > Thank Eric.
> >
> > Kevin,
> >
> > do you want me to resend the series with these cover letter/cc fixes or
> > is it okay this time?
>
> It's not worth a respin. I'm just waiting for an Acked-by (or whatever
> other outcome of a review) from Keith before I merge this.
Given that you got the Ack a while ago is there any chance to get this data
integrity fix in before qemu 2.4?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [Qemu-block] NVMe volatile write cache fixes
[not found] <1434016899-18643-1-git-send-email-hch@lst.de>
2015-06-11 12:26 ` [Qemu-devel] [Qemu-block] NVMe volatile write cache fixes Eric Blake
@ 2015-07-08 10:05 ` Kevin Wolf
1 sibling, 0 replies; 5+ messages in thread
From: Kevin Wolf @ 2015-07-08 10:05 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Keith Busch, qemu-devel, qemu-block
Am 11.06.2015 um 12:01 hat Christoph Hellwig geschrieben:
> The first patch ensures that flush actually flushes data so that
> data integrity is preserved, the second fixe up WCE reporting.
Thanks, applied to the block branch for 2.4-rc1.
Kevin
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-07-08 10:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1434016899-18643-1-git-send-email-hch@lst.de>
2015-06-11 12:26 ` [Qemu-devel] [Qemu-block] NVMe volatile write cache fixes Eric Blake
2015-06-17 11:59 ` Christoph Hellwig
2015-06-17 12:24 ` Kevin Wolf
2015-07-04 4:58 ` Christoph Hellwig
2015-07-08 10:05 ` Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).