From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: amit.shah@redhat.com, qemu-devel@nongnu.org,
"Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>,
quintela@redhat.com
Subject: Re: [Qemu-devel] [PATCH] Migration compatibility for serial
Date: Wed, 17 Jun 2015 13:58:31 +0200 [thread overview]
Message-ID: <20150617135716-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <55816039.3080103@redhat.com>
On Wed, Jun 17, 2015 at 01:55:37PM +0200, Paolo Bonzini wrote:
>
>
> On 17/06/2015 13:54, Michael S. Tsirkin wrote:
> >>> > >> > Where, in the specific case of migration?
> > > > Just look at hour compat flags.
> > > >
> > > > For example (intentionally using serial here):
> > > > {\
> > > > .driver = "pci-serial",\
> > > > .property = "prog_if",\
> > > > .value = stringify(0),\
> > > > },\
> > > > {\
> > > > .driver = "pci-serial-2x",\
> > > > .property = "prog_if",\
> > > > .value = stringify(0),\
> > > > },\
> > > > {\
> > > > .driver = "pci-serial-4x",\
> > > > .property = "prog_if",\
> > > > .value = stringify(0),\
> > > > },\
> > > >
> > > > apparently some clients check the specific prog if
> > > > value, completely breaking if the value was incorrect.
> > > > So we fixed it for new machine types but not old ones.
> > >
> > > That has nothing to do with migration.
> >
> > If you change prog_if migration fails.
>
> No, it doesn't. The guest misbehaves maybe, but the migration format is
> not affected.
>
> Paolo
I just tried, set prog_if to different values, sure it failed.
Here's another one, at random:
Author: Michael S. Tsirkin <mst@redhat.com>
Date: Thu Feb 14 19:11:27 2013 +0200
e1000: unbreak the guest network migration to 1.3
QEMU 1.3 does not emulate the link auto negotiation, so if migrate to a
1.3 machine during link auto negotiation, the guest link will be set to down.
Fix this by just disabling auto negotiation for 1.3 and older.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
--
MST
next prev parent reply other threads:[~2015-06-17 11:58 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 18:54 [Qemu-devel] [PATCH] Migration compatibility for serial Dr. David Alan Gilbert (git)
2015-06-16 20:49 ` Michael S. Tsirkin
2015-06-17 9:09 ` Dr. David Alan Gilbert
2015-06-17 6:52 ` Markus Armbruster
2015-06-17 6:58 ` Michael S. Tsirkin
2015-06-17 7:11 ` Markus Armbruster
2015-06-17 7:25 ` Michael S. Tsirkin
2015-06-17 7:41 ` Paolo Bonzini
2015-06-17 7:52 ` Michael S. Tsirkin
2015-06-17 8:11 ` Paolo Bonzini
2015-06-17 10:13 ` Michael S. Tsirkin
2015-06-17 10:48 ` Juan Quintela
2015-06-17 10:51 ` Dr. David Alan Gilbert
2015-06-17 10:56 ` Michael S. Tsirkin
2015-06-17 10:59 ` Dr. David Alan Gilbert
2015-06-17 11:36 ` Michael S. Tsirkin
2015-06-17 10:55 ` Michael S. Tsirkin
2015-06-17 11:33 ` Paolo Bonzini
2015-06-17 11:40 ` Dr. David Alan Gilbert
2015-06-17 11:44 ` Paolo Bonzini
2015-06-17 11:48 ` Michael S. Tsirkin
2015-06-17 12:07 ` Dr. David Alan Gilbert
2015-06-17 12:20 ` Paolo Bonzini
2015-06-17 14:44 ` Michael S. Tsirkin
2015-06-17 16:34 ` Juan Quintela
2015-06-17 16:39 ` Michael S. Tsirkin
2015-06-17 16:40 ` Paolo Bonzini
2015-06-17 11:45 ` Michael S. Tsirkin
2015-06-17 11:53 ` Paolo Bonzini
2015-06-17 11:54 ` Michael S. Tsirkin
2015-06-17 11:55 ` Paolo Bonzini
2015-06-17 11:58 ` Michael S. Tsirkin [this message]
2015-06-17 12:20 ` Paolo Bonzini
2015-06-17 14:50 ` Michael S. Tsirkin
2015-06-17 16:16 ` Paolo Bonzini
2015-06-17 16:34 ` Michael S. Tsirkin
2015-06-17 16:35 ` Paolo Bonzini
2015-06-17 9:26 ` Juan Quintela
2015-06-17 10:37 ` Michael S. Tsirkin
2015-06-17 8:37 ` Dr. David Alan Gilbert
2015-06-17 8:49 ` Paolo Bonzini
2015-06-17 9:38 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150617135716-mutt-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=amit.shah@redhat.com \
--cc=dgilbert@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).