Re: [Qemu-devel] [PATCH 01/11] runstate: Add runstate store

["Dr. David Alan Gilbert" <dgilbert@redhat.com>]

* Juan Quintela (quintela@redhat.com) wrote:
> This allows us to store the current state to send it through migration.
> 
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  include/sysemu/sysemu.h |  1 +
>  vl.c                    | 12 ++++++++++++
>  2 files changed, 13 insertions(+)
> 
> diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h
> index 0304aa7..d7bec42 100644
> --- a/include/sysemu/sysemu.h
> +++ b/include/sysemu/sysemu.h
> @@ -28,6 +28,7 @@ bool runstate_check(RunState state);
>  void runstate_set(RunState new_state);
>  int runstate_is_running(void);
>  bool runstate_needs_reset(void);
> +bool runstate_store(char *str, size_t size);
>  typedef struct vm_change_state_entry VMChangeStateEntry;
>  typedef void VMChangeStateHandler(void *opaque, int running, RunState state);
> 
> diff --git a/vl.c b/vl.c
> index 2201e27..c659a00 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -630,6 +630,18 @@ bool runstate_check(RunState state)
>      return current_run_state == state;
>  }
> 
> +bool runstate_store(char *str, size_t size)
> +{
> +    const char *state = RunState_lookup[current_run_state];
> +    size_t len = strlen(state) + 1;
> +
> +    if (len > size) {
> +        return false;
> +    }
> +    memcpy(str, state, len);
> +    return true;
> +}
> +

It seems a lot of work for a status string; but OK.

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

>  static void runstate_init(void)
>  {
>      const RunStateTransition *p;
> -- 
> 2.4.3
> 
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK