From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41089)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pcacjr@zytor.com>) id 1Z5PLS-0000pN-GK
	for qemu-devel@nongnu.org; Wed, 17 Jun 2015 22:14:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pcacjr@zytor.com>) id 1Z5PLP-0003P9-9U
	for qemu-devel@nongnu.org; Wed, 17 Jun 2015 22:14:22 -0400
Received: from terminus.zytor.com ([2001:1868:205::10]:45646
	helo=mail.zytor.com) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pcacjr@zytor.com>) id 1Z5PLP-0003P3-0b
	for qemu-devel@nongnu.org; Wed, 17 Jun 2015 22:14:19 -0400
Date: Wed, 17 Jun 2015 23:14:04 -0300
From: Paulo Alcantara <pcacjr@zytor.com>
Message-ID: <20150617231404.38eeca96@zytor.com>
In-Reply-To: <20150617152800-mutt-send-email-mst@redhat.com>
References: <1433023482-25721-1-git-send-email-pcacjr@zytor.com>
	<1433202521-3094-1-git-send-email-pcacjr@zytor.com>
	<1433202521-3094-2-git-send-email-pcacjr@zytor.com>
	<20150617152800-mutt-send-email-mst@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 2/3] target-i386: reserve RCRB mmio
 space in ACPI DSDT table
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: pbonzini@redhat.com, seabios@seabios.org, Paulo Alcantara <pcacjr@gmail.com>, qemu-devel@nongnu.org

On Wed, 17 Jun 2015 15:33:07 +0200
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> On Mon, Jun 01, 2015 at 08:48:40PM -0300, Paulo Alcantara wrote:
> > v1 -> v2:
> >   * s/PDRC/CCR/ for clarity and match ICH9 spec
> >   * remove unnecessary OperationRegion for RCRB
> 
> changelog should come after ---.

Ok.

> An empty commit log is too terse I think.
> Could you quote spec in the changelog?

Yes, sure.

> 
> > Signed-off-by: Paulo Alcantara <pcacjr@zytor.com>
> > ---
> >  hw/i386/q35-acpi-dsdt.dsl     |  14 ++++++++++++++
> >  tests/acpi-test-data/q35/DSDT | Bin 7666 -> 7723 bytes
> >  2 files changed, 14 insertions(+)
> > 
> > diff --git a/hw/i386/q35-acpi-dsdt.dsl b/hw/i386/q35-acpi-dsdt.dsl
> > index 16eaca3..92675c8 100644
> > --- a/hw/i386/q35-acpi-dsdt.dsl
> > +++ b/hw/i386/q35-acpi-dsdt.dsl
> > @@ -114,6 +114,20 @@ DefinitionBlock (
> >          }
> >      }
> >  
> > +/****************************************************************
> > + * Chipset Configuration Registers
> > + ****************************************************************/
> > +Scope(\_SB.PCI0) {
> > +    Device (CCR) {
> > +        Name (_HID, EISAID("PNP0C02"))
> > +        Name (_UID, 1)
> > +
> > +        Name (_CRS, ResourceTemplate() {
> > +	    Memory32Fixed(ReadWrite, 0xfed1c000, 0x00004000) //
> > RCBA
> 
> Indent a bit more please.

Ok.

Thanks,

Paulo

-- 
Paulo Alcantara, C.E.S.A.R
Speaking for myself only.