Re: [Qemu-devel] [PATCH 11/11] migration: Add migration events on target side

["Dr. David Alan Gilbert" <dgilbert@redhat.com>]

* Juan Quintela (quintela@redhat.com) wrote:
> We reuse the migration events from the source side, sending them on the
> appropiate place.
> 
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> ---
>  migration/migration.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/migration/migration.c b/migration/migration.c
> index 3637d36..2b4fd55 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -218,6 +218,7 @@ void qemu_start_incoming_migration(const char *uri, Error **errp)
>  {
>      const char *p;
> 
> +    qapi_event_send_migration(MIGRATION_STATUS_SETUP, &error_abort);

Try and avoid error_abort - you don't want to trigger an assert (and associated
core etc) if it's just something like the monitor disconnecting.
(And anyway in this case you have an errp).

Dave

>      if (!strcmp(uri, "defer")) {
>          deferred_incoming_migration(errp);
>      } else if (strstart(uri, "tcp:", &p)) {
> @@ -246,7 +247,7 @@ static void process_incoming_migration_co(void *opaque)
>      int ret;
> 
>      migration_incoming_state_new(f);
> -
> +    qapi_event_send_migration(MIGRATION_STATUS_ACTIVE, &error_abort);
>      ret = qemu_loadvm_state(f);
> 
>      qemu_fclose(f);
> @@ -254,10 +255,12 @@ static void process_incoming_migration_co(void *opaque)
>      migration_incoming_state_destroy();
> 
>      if (ret < 0) {
> +        qapi_event_send_migration(MIGRATION_STATUS_FAILED, &error_abort);
>          error_report("load of migration failed: %s", strerror(-ret));
>          migrate_decompress_threads_join();
>          exit(EXIT_FAILURE);
>      }
> +    qapi_event_send_migration(MIGRATION_STATUS_COMPLETED, &error_abort);
>      qemu_announce_self();
> 
>      /* Make sure all file formats flush their mutable metadata */
> -- 
> 2.4.3
> 
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK