From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56123) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5XfF-0003Da-HD for qemu-devel@nongnu.org; Thu, 18 Jun 2015 07:07:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5XfE-0001Gz-BQ for qemu-devel@nongnu.org; Thu, 18 Jun 2015 07:07:21 -0400 Date: Thu, 18 Jun 2015 14:07:09 +0300 From: Dimitris Aragiorgis Message-ID: <20150618110708.GA880@arr> References: <1432115859-11413-1-git-send-email-dimara@arrikto.com> <20150529051534.GA20809@arr> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Kj7319i9nmIyA2yE" Content-Disposition: inline In-Reply-To: <20150529051534.GA20809@arr> Subject: Re: [Qemu-devel] [PATCH v4 0/5] Some fixes related to scsi-generic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, pbonzini@redhat.com, stefanha@redhat.com, qemu-block@nongnu.org --Kj7319i9nmIyA2yE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, did you have the time to take a look at this? Is there anything pending from my side? Thanks, dimara * Dimitris Aragiorgis [2015-05-29 08:15:34 +0300]: > Hi, >=20 > * Dimitris Aragiorgis [2015-05-20 12:57:34 +0300]: >=20 > > Hi all, > >=20 > > These four patches make slight changes to the way QEMU handles SCSI > > generic devices to fix a number of small problems. > >=20 > > I am sending them against the master branch, since I don't know if they > > can be considered bugfixes. > >=20 > > Thanks, > > dimara > >=20 > > v4 (rebased to current master): > > * Avoid errno clobbering with DPRINTF + strerror() (Eric's comment) > > * Use {} in #define macro even if it is not necessary (single commands) > >=20 >=20 > Any news on this? >=20 > Thanks, > dimara >=20 >=20 > > v3 (rebased to current master): > > * Avoid bit-rot in DPRINTF (adopt Eric's suggestion) > > * Address Kevin's comments (DEBUF_FLOPPY, line > 80 chars, SG device) > > * Mention Kevin's comment wrt disk flush in the corresponding commit > >=20 > > v2: > > * remove duplicate check for sg inside iscsi_co_flush() > > * remove DEBUG_BLOCK_PRINT in block/raw-posix.c > > * use DPRINTF for debugging in block/raw-posix.c > >=20 > > PS: Paolo suggested to use a tracepoint inside hdev_is_sg() but I chose= DPRINTF > > instead. It would make sense to add a tracepoint for bdrv_is_sg() (just= like > > most bdrv_* commands) but this is too much for now since it just return= s the > > bs->sg flag (and is not an actual driver function). If you insist I'll = change > > it in v3. > >=20 > > Dimitris Aragiorgis (5): > > block: Use bdrv_is_sg() everywhere > > Fix migration in case of scsi-generic > > raw-posix: DPRINTF instead of DEBUG_BLOCK_PRINT > > raw-posix: Use DPRINTF for DEBUG_FLOPPY > > raw-posix: Introduce hdev_is_sg() > >=20 > > block.c | 6 ++-- > > block/io.c | 3 +- > > block/iscsi.c | 4 --- > > block/raw-posix.c | 91 +++++++++++++++++++++++++++++++--------------= -------- > > 4 files changed, 58 insertions(+), 46 deletions(-) > >=20 > > --=20 > > 1.7.10.4 > >=20 --Kj7319i9nmIyA2yE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQEcBAEBAgAGBQJVgqZcAAoJEHFDHex6CBG9qyoH/1UfHgkn5xUDd0UJCcDNRRKc Fb8GBVTIUQ9SKpJjb8078RZzEDgvRCFVSvrRVoE1K6SaTpalvaiL2r2ux4DTRUHy OuGf9peXC/Y2I6Uj57BiRKx+W9rpgZ8pkdFUsd8t3y86PK1ifI4Pzkrigi5eSy/Q 719TLA7Zu5wnefSCvWKlVRx8qoNkOMpQr3cyjd1rk9u4PRitfGlmpf7ddsd9nvIc QDR4meomgx42frluPrWx2++DK46J0r2LTYT8jiXiUnkSR4tDMDIlHwxO3Y+EfoY8 CtyTYGRRTxXLvoH9+Z/KJ5afoW5YA5d/8WO3We3eIddvE9Idxk898Y+0QQYTx7I= =d62p -----END PGP SIGNATURE----- --Kj7319i9nmIyA2yE--