From: Paul Donohue <qemu-devel@PaulSD.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] qemu-timer: Call clock reset notifiers on forward jumps
Date: Thu, 18 Jun 2015 08:58:19 -0400 [thread overview]
Message-ID: <20150618125819.GA7886@TopQuark.net> (raw)
In-Reply-To: <55817D66.2090303@redhat.com>
On Wed, Jun 17, 2015 at 04:00:06PM +0200, Paolo Bonzini wrote:
> On 12/06/2015 16:08, Paul Donohue wrote:
> > +static inline int64_t get_max_clock_jump(void)
> > +{
> > + // This should be small enough to prevent excessive interrupts from being
> > + // generated by the RTC on clock jumps, but large enough to avoid frequent
> > + // unnecessary resets in idle VMs.
> This is not how comments are layed out in QEMU...
Oops. Sorry, I'm not sure how I missed that. Force of habit from
other projects, I guess...
> > + return 60 * get_ticks_per_sec();
> > +}
> > +
> > /*
> > * * Low level clock functions
> > * */
> ... and it also looks like your editor has mangled this patch.
Ugh, yes. I do remember noticing that, and I thought I fixed it, but
apparently not.
I will correct and send an updated patch.
next prev parent reply other threads:[~2015-06-18 12:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-12 14:05 [Qemu-devel] [PATCH 0/2] qemu-timer/mc146818rtc: fix timer issues related to clock changes Paul Donohue
2015-06-12 14:08 ` [Qemu-devel] [PATCH 1/2] qemu-timer: Call clock reset notifiers on forward jumps Paul Donohue
2015-06-17 14:00 ` Paolo Bonzini
2015-06-18 12:58 ` Paul Donohue [this message]
2015-06-18 13:17 ` Paolo Bonzini
2015-06-12 14:10 ` [Qemu-devel] [PATCH 2/2] mc146818rtc: Reset the periodic timer on load Paul Donohue
2015-06-17 14:01 ` Paolo Bonzini
2015-06-18 14:36 ` Paul Donohue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150618125819.GA7886@TopQuark.net \
--to=qemu-devel@paulsd.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).