Re: [Qemu-devel] [PATCH/RFC] s390x/ipl: Fix boot if no bootindex was specified

[Aurelien Jarno <aurelien@aurel32.net>]

On 2015-06-18 17:54, Christian Borntraeger wrote:
> commit fa92e218df1d ("s390x/ipl: avoid sign extension") introduced
> a regression:
> 
> qemu-system-s390x -drive file=/home/cborntra/image.zhyp409,format=qcow2
> does not boot, the bios states
> "No virtio-blk device found!"
> 
> adding bootindex=1 does boot.
> 
> The reason is that the uint32_t as return value will not do the right
> thing for the return -1 (default without bootindex).
> The bios itself, will interpret a 64bit -1 as autodetect (but it will
> interpret 32bit -1 as ccw device address ff.ff.ffff)
> 
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Cornelia Huck <cornelia.huck@de.ibm.com>
> Cc: qemu-stable@nongnu.org # v2.3.0
> ---
>  hw/s390x/ipl.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Thanks for the quick patch, I confirmed it works.

Tested-by: Aurelien Jarno <aurelien@aurel32.net>
Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                 http://www.aurel32.net