From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58979)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1Z5kk7-00067V-Fv
	for qemu-devel@nongnu.org; Thu, 18 Jun 2015 21:05:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1Z5kk6-0002K5-Jn
	for qemu-devel@nongnu.org; Thu, 18 Jun 2015 21:05:15 -0400
Date: Fri, 19 Jun 2015 09:05:06 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20150619010506.GC2202@ad.nay.redhat.com>
References: <1433926791-10580-1-git-send-email-famz@redhat.com>
	<1433926791-10580-3-git-send-email-famz@redhat.com>
	<20150616135738.GA3132@stefanha-thinkpad.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150616135738.GA3132@stefanha-thinkpad.redhat.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 2/9] iohandler: Use aio code
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org, Stefan Weil <sw@weilnetz.de>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Jan Kiszka <jan.kiszka@siemens.com>, Paolo Bonzini <pbonzini@redhat.com>

On Tue, 06/16 14:57, Stefan Hajnoczi wrote:
> On Wed, Jun 10, 2015 at 04:59:44PM +0800, Fam Zheng wrote:
> > diff --git a/iohandler.c b/iohandler.c
> > index 826f713..f5d7704 100644
> > --- a/iohandler.c
> > +++ b/iohandler.c
> > @@ -32,111 +32,39 @@
> >  #include <sys/wait.h>
> >  #endif
> >  
> > -typedef struct IOHandlerRecord {
> > -    IOHandler *fd_read;
> > -    IOHandler *fd_write;
> > -    void *opaque;
> > -    QLIST_ENTRY(IOHandlerRecord) next;
> > -    int fd;
> > -    int pollfds_idx;
> > -    bool deleted;
> > -} IOHandlerRecord;
> > +static AioContext *iohandler_ctx;
> 
> Please include a comment explaining why this AioContext is needed in
> addition to the global qemu_aio_context.

OK!

It's needed because iohandlers shouldn't be polled by aio_poll().

Fam