From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60098)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1Z5rTh-0007nf-92
	for qemu-devel@nongnu.org; Fri, 19 Jun 2015 04:16:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1Z5rTb-0003ve-54
	for qemu-devel@nongnu.org; Fri, 19 Jun 2015 04:16:45 -0400
Received: from mx1.redhat.com ([209.132.183.28]:37346)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1Z5rTa-0003vY-TB
	for qemu-devel@nongnu.org; Fri, 19 Jun 2015 04:16:39 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (Postfix) with ESMTPS id 9973B2B64BC
	for <qemu-devel@nongnu.org>; Fri, 19 Jun 2015 08:16:38 +0000 (UTC)
Date: Fri, 19 Jun 2015 10:16:32 +0200
From: Thomas Huth <thuth@redhat.com>
Message-ID: <20150619101632.7f9002ee@thh440s>
In-Reply-To: <1434699834-27593-1-git-send-email-mst@redhat.com>
References: <1434699834-27593-1-git-send-email-mst@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] tap: fix non-linux build
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

On Fri, 19 Jun 2015 09:44:00 +0200
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> tap_fd_set_vnet_le/tap_fd_set_vnet_be was missing,
> fix it up.
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  net/tap-aix.c     | 10 ++++++++++
>  net/tap-bsd.c     | 10 ++++++++++
>  net/tap-haiku.c   | 10 ++++++++++
>  net/tap-solaris.c | 10 ++++++++++
>  net/tap-win32.c   | 10 ++++++++++
>  5 files changed, 50 insertions(+)
> 
> diff --git a/net/tap-aix.c b/net/tap-aix.c
> index 18fdbf3..e84fc39 100644
> --- a/net/tap-aix.c
> +++ b/net/tap-aix.c
> @@ -55,6 +55,16 @@ void tap_fd_set_vnet_hdr_len(int fd, int len)
>  {
>  }
>  
> +int tap_fd_set_vnet_le(int fd, int is_le)
> +{
> +    return -EINVAL;
> +}
> +
> +int tap_fd_set_vnet_be(int fd, int is_be)
> +{
> +    return -EINVAL;
> +}
> +
>  void tap_fd_set_offload(int fd, int csum, int tso4,
>                          int tso6, int ecn, int ufo)
>  {
> diff --git a/net/tap-bsd.c b/net/tap-bsd.c
> index 5889920..7028d9b 100644
> --- a/net/tap-bsd.c
> +++ b/net/tap-bsd.c
> @@ -196,6 +196,16 @@ void tap_fd_set_vnet_hdr_len(int fd, int len)
>  {
>  }
>  
> +int tap_fd_set_vnet_le(int fd, int is_le)
> +{
> +    return -EINVAL;
> +}
> +
> +int tap_fd_set_vnet_be(int fd, int is_be)
> +{
> +    return -EINVAL;
> +}
> +
>  void tap_fd_set_offload(int fd, int csum, int tso4,
>                          int tso6, int ecn, int ufo)
>  {
> diff --git a/net/tap-haiku.c b/net/tap-haiku.c
> index d18590c..2e738ec 100644
> --- a/net/tap-haiku.c
> +++ b/net/tap-haiku.c
> @@ -55,6 +55,16 @@ void tap_fd_set_vnet_hdr_len(int fd, int len)
>  {
>  }
>  
> +int tap_fd_set_vnet_le(int fd, int is_le)
> +{
> +    return -EINVAL;
> +}
> +
> +int tap_fd_set_vnet_be(int fd, int is_be)
> +{
> +    return -EINVAL;
> +}
> +
>  void tap_fd_set_offload(int fd, int csum, int tso4,
>                          int tso6, int ecn, int ufo)
>  {
> diff --git a/net/tap-solaris.c b/net/tap-solaris.c
> index 90b2fd1..0f60f78 100644
> --- a/net/tap-solaris.c
> +++ b/net/tap-solaris.c
> @@ -223,6 +223,16 @@ void tap_fd_set_vnet_hdr_len(int fd, int len)
>  {
>  }
>  
> +int tap_fd_set_vnet_le(int fd, int is_le)
> +{
> +    return -EINVAL;
> +}
> +
> +int tap_fd_set_vnet_be(int fd, int is_be)
> +{
> +    return -EINVAL;
> +}
> +
>  void tap_fd_set_offload(int fd, int csum, int tso4,
>                          int tso6, int ecn, int ufo)
>  {
> diff --git a/net/tap-win32.c b/net/tap-win32.c
> index f6fc961..625d53c 100644
> --- a/net/tap-win32.c
> +++ b/net/tap-win32.c
> @@ -688,6 +688,16 @@ void tap_fd_set_vnet_hdr_len(int fd, int len)
>  {
>  }
>  
> +int tap_fd_set_vnet_le(int fd, int is_le)
> +{
> +    return -EINVAL;
> +}
> +
> +int tap_fd_set_vnet_be(int fd, int is_be)
> +{
> +    return -EINVAL;
> +}
> +
>  static void tap_using_vnet_hdr(NetClientState *nc, bool using_vnet_hdr)
>  {
>  }

Reviewed-by: Thomas Huth <thuth@redhat.com>