From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32962) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5sZm-0006D0-P9 for qemu-devel@nongnu.org; Fri, 19 Jun 2015 05:27:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5sZf-0003u7-Gq for qemu-devel@nongnu.org; Fri, 19 Jun 2015 05:27:06 -0400 Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:49392) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5sZf-0003sO-6m for qemu-devel@nongnu.org; Fri, 19 Jun 2015 05:26:59 -0400 Received: from /spool/local by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 19 Jun 2015 10:26:55 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 400622190066 for ; Fri, 19 Jun 2015 10:26:32 +0100 (BST) Received: from d06av12.portsmouth.uk.ibm.com (d06av12.portsmouth.uk.ibm.com [9.149.37.247]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t5J9Qrq727328664 for ; Fri, 19 Jun 2015 09:26:53 GMT Received: from d06av12.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av12.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t5J9QrRQ028334 for ; Fri, 19 Jun 2015 03:26:53 -0600 Date: Fri, 19 Jun 2015 11:26:49 +0200 From: Greg Kurz Message-ID: <20150619112649.400cd8fd@bahia.local> In-Reply-To: <1434699834-27593-1-git-send-email-mst@redhat.com> References: <1434699834-27593-1-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] tap: fix non-linux build List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Jason Wang , qemu-devel@nongnu.org, Stefan Hajnoczi On Fri, 19 Jun 2015 09:44:00 +0200 "Michael S. Tsirkin" wrote: > tap_fd_set_vnet_le/tap_fd_set_vnet_be was missing, > fix it up. > > Signed-off-by: Michael S. Tsirkin > --- > net/tap-aix.c | 10 ++++++++++ > net/tap-bsd.c | 10 ++++++++++ > net/tap-haiku.c | 10 ++++++++++ > net/tap-solaris.c | 10 ++++++++++ > net/tap-win32.c | 10 ++++++++++ > 5 files changed, 50 insertions(+) > > diff --git a/net/tap-aix.c b/net/tap-aix.c > index 18fdbf3..e84fc39 100644 > --- a/net/tap-aix.c > +++ b/net/tap-aix.c > @@ -55,6 +55,16 @@ void tap_fd_set_vnet_hdr_len(int fd, int len) > { > } > > +int tap_fd_set_vnet_le(int fd, int is_le) > +{ > + return -EINVAL; > +} > + > +int tap_fd_set_vnet_be(int fd, int is_be) > +{ > + return -EINVAL; > +} > + > void tap_fd_set_offload(int fd, int csum, int tso4, > int tso6, int ecn, int ufo) > { > diff --git a/net/tap-bsd.c b/net/tap-bsd.c > index 5889920..7028d9b 100644 > --- a/net/tap-bsd.c > +++ b/net/tap-bsd.c > @@ -196,6 +196,16 @@ void tap_fd_set_vnet_hdr_len(int fd, int len) > { > } > > +int tap_fd_set_vnet_le(int fd, int is_le) > +{ > + return -EINVAL; > +} > + > +int tap_fd_set_vnet_be(int fd, int is_be) > +{ > + return -EINVAL; > +} > + > void tap_fd_set_offload(int fd, int csum, int tso4, > int tso6, int ecn, int ufo) > { > diff --git a/net/tap-haiku.c b/net/tap-haiku.c > index d18590c..2e738ec 100644 > --- a/net/tap-haiku.c > +++ b/net/tap-haiku.c > @@ -55,6 +55,16 @@ void tap_fd_set_vnet_hdr_len(int fd, int len) > { > } > > +int tap_fd_set_vnet_le(int fd, int is_le) > +{ > + return -EINVAL; > +} > + > +int tap_fd_set_vnet_be(int fd, int is_be) > +{ > + return -EINVAL; > +} > + > void tap_fd_set_offload(int fd, int csum, int tso4, > int tso6, int ecn, int ufo) > { > diff --git a/net/tap-solaris.c b/net/tap-solaris.c > index 90b2fd1..0f60f78 100644 > --- a/net/tap-solaris.c > +++ b/net/tap-solaris.c > @@ -223,6 +223,16 @@ void tap_fd_set_vnet_hdr_len(int fd, int len) > { > } > > +int tap_fd_set_vnet_le(int fd, int is_le) > +{ > + return -EINVAL; > +} > + > +int tap_fd_set_vnet_be(int fd, int is_be) > +{ > + return -EINVAL; > +} > + > void tap_fd_set_offload(int fd, int csum, int tso4, > int tso6, int ecn, int ufo) > { > diff --git a/net/tap-win32.c b/net/tap-win32.c > index f6fc961..625d53c 100644 > --- a/net/tap-win32.c > +++ b/net/tap-win32.c > @@ -688,6 +688,16 @@ void tap_fd_set_vnet_hdr_len(int fd, int len) > { > } > > +int tap_fd_set_vnet_le(int fd, int is_le) > +{ > + return -EINVAL; > +} > + > +int tap_fd_set_vnet_be(int fd, int is_be) > +{ > + return -EINVAL; > +} > + > static void tap_using_vnet_hdr(NetClientState *nc, bool using_vnet_hdr) > { > } I couldn't setup a build environment on a non-linux platform (tried AIX but I miss to many packages), so I won't give a Tested-by... patch is trivial though so: Reviewed-by: Greg Kurz