From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51833) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5tL4-0003KO-Ir for qemu-devel@nongnu.org; Fri, 19 Jun 2015 06:16:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5tKz-000849-Ta for qemu-devel@nongnu.org; Fri, 19 Jun 2015 06:15:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38623) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5tKy-00083i-WC for qemu-devel@nongnu.org; Fri, 19 Jun 2015 06:15:53 -0400 Date: Fri, 19 Jun 2015 12:15:50 +0200 From: "Michael S. Tsirkin" Message-ID: <20150619121512-mutt-send-email-mst@redhat.com> References: <20150619095853.12531.15450.stgit@bahia.huguette.org> <20150619120638-mutt-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] vhost_net: fix misuse of assert() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers On Fri, Jun 19, 2015 at 11:13:40AM +0100, Peter Maydell wrote: > On 19 June 2015 at 11:07, Michael S. Tsirkin wrote: > > On Fri, Jun 19, 2015 at 12:00:53PM +0200, Greg Kurz wrote: > >> In case NDEBUG is defined, assert() expands to nothing and > >> vhost_net_set_vnet_endian() doesn't get called... > >> > >> Suggested-by: Thomas Huth > >> Signed-off-by: Greg Kurz > > > > Not sure what the point is. > > We don't support building with NDEBUG. > > Putting functional behaviour inside an assert() is still a really > bad idea. If you're reading the code you probably skim over the > assert() as not functionally relevant... > > -- PMM I can apply this if commit log explains it's a readability enhancement, not a bugfix. -- MST