From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38264)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1Z5vMU-0008Tw-5D
	for qemu-devel@nongnu.org; Fri, 19 Jun 2015 08:25:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1Z5vMT-0000QD-Bh
	for qemu-devel@nongnu.org; Fri, 19 Jun 2015 08:25:34 -0400
Date: Fri, 19 Jun 2015 13:25:24 +0100
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20150619122524.GI11189@stefanha-thinkpad.redhat.com>
References: <1432115859-11413-1-git-send-email-dimara@arrikto.com>
	<1432115859-11413-4-git-send-email-dimara@arrikto.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="jQIvE3yXcK9X9HBh"
Content-Disposition: inline
In-Reply-To: <1432115859-11413-4-git-send-email-dimara@arrikto.com>
Subject: Re: [Qemu-devel] [PATCH v4 3/5] raw-posix: DPRINTF instead of
	DEBUG_BLOCK_PRINT
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Dimitris Aragiorgis <dimara@arrikto.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org


--jQIvE3yXcK9X9HBh
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, May 20, 2015 at 12:57:37PM +0300, Dimitris Aragiorgis wrote:
> Building the QEMU tools fails if we #define DEBUG_BLOCK inside
> block/raw-posix.c. Here instead of adding qemu-log.o in block-obj-y
> so that DEBUG_BLOCK_PRINT can be used, we substitute the latter with
> a simple DPRINTF() (that does not cause bit-rot).
>=20
> Signed-off-by: Dimitris Aragiorgis <dimara@arrikto.com>
> ---
>  block/raw-posix.c |   26 ++++++++++++++++++--------
>  1 file changed, 18 insertions(+), 8 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

--jQIvE3yXcK9X9HBh
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJVhAo0AAoJEJykq7OBq3PI1lcH/2coNQx74qB5tTDSY5z91aQb
k2EdWO/1yV5dFK0F5Y3/l80PWjEtPwm9Qv6R4/MpQGXKa0FESOGUncHDZP7HeK7S
Xb0E15RAZ4pZa+XwmKmF4XHBc0zFgDuUz2kVl5wpvYL6jR+dG/uzFAI+QJtNCugP
sz2Ka9wH2ZB7qRX1vE117VNqlIcCVJwKdExNPiHBkWdBN3KjMmnX5FYiQ1+uGIXZ
RDCYK00v6c0pmaek1Mp0kreVeaxqzx3NZVypeXNO2eIPjMC+Uwb6blONNR/Y8+e+
+uuBiixpEHmh485aruq8GYPP9V1LPrKQE6TtCig58vBt7AbqXsgUzqi+xmUL1cQ=
=6Ww3
-----END PGP SIGNATURE-----

--jQIvE3yXcK9X9HBh--