From: Stefan Hajnoczi <stefanha@redhat.com>
To: Dimitris Aragiorgis <dimara@arrikto.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4 5/5] raw-posix: Introduce hdev_is_sg()
Date: Fri, 19 Jun 2015 13:33:02 +0100 [thread overview]
Message-ID: <20150619123302.GK11189@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1432115859-11413-6-git-send-email-dimara@arrikto.com>
[-- Attachment #1: Type: text/plain, Size: 267 bytes --]
On Wed, May 20, 2015 at 12:57:39PM +0300, Dimitris Aragiorgis wrote:
> This is very fragile, e.g. it fails with symlinks or relative paths.
This is not true since realpath(3) is used to resolve symlinks and
product an absolute path.
Is this patch really necessary?
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-06-19 12:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 9:57 [Qemu-devel] [PATCH v4 0/5] Some fixes related to scsi-generic Dimitris Aragiorgis
2015-05-20 9:57 ` [Qemu-devel] [PATCH v4 1/5] block: Use bdrv_is_sg() everywhere Dimitris Aragiorgis
2015-06-19 12:18 ` Stefan Hajnoczi
2015-05-20 9:57 ` [Qemu-devel] [PATCH v4 2/5] Fix migration in case of scsi-generic Dimitris Aragiorgis
2015-06-19 12:23 ` Stefan Hajnoczi
2015-05-20 9:57 ` [Qemu-devel] [PATCH v4 3/5] raw-posix: DPRINTF instead of DEBUG_BLOCK_PRINT Dimitris Aragiorgis
2015-06-18 20:05 ` Eric Blake
2015-06-19 12:25 ` Stefan Hajnoczi
2015-05-20 9:57 ` [Qemu-devel] [PATCH v4 4/5] raw-posix: Use DPRINTF for DEBUG_FLOPPY Dimitris Aragiorgis
2015-06-18 20:14 ` Eric Blake
2015-06-19 12:25 ` Stefan Hajnoczi
2015-05-20 9:57 ` [Qemu-devel] [PATCH v4 5/5] raw-posix: Introduce hdev_is_sg() Dimitris Aragiorgis
2015-06-18 20:16 ` Eric Blake
2015-06-19 12:33 ` Stefan Hajnoczi [this message]
2015-06-22 10:18 ` Dimitris Aragiorgis
2015-06-22 12:33 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2015-05-29 5:15 ` [Qemu-devel] [PATCH v4 0/5] Some fixes related to scsi-generic Dimitris Aragiorgis
2015-06-18 11:07 ` Dimitris Aragiorgis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150619123302.GK11189@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=dimara@arrikto.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).