From: Stefan Hajnoczi <stefanha@gmail.com>
To: Ting Wang <kathy.wangting@huawei.com>
Cc: Keith Busch <keith.busch@intel.com>,
Lu Lina <lina.lulina@huawei.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] nvme: Fix memleak in nvme_dma_read_prp
Date: Fri, 19 Jun 2015 13:57:27 +0100 [thread overview]
Message-ID: <20150619125727.GB18007@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1434695254-69808-1-git-send-email-kathy.wangting@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 961 bytes --]
On Fri, Jun 19, 2015 at 02:27:34PM +0800, Ting Wang wrote:
Please CC the maintainer of this source file:
$ scripts/get_maintainer.pl -f hw/block/nvme.c
Keith Busch <keith.busch@intel.com> (supporter:nvme)
Kevin Wolf <kwolf@redhat.com> (supporter:Block layer core)
qemu-block@nongnu.org (open list:nvme)
> From: Lu Lina <lina.lulina@huawei.com>
>
> Signed-off-by: Lu Lina <lina.lulina@huawei.com>
Your Signed-off-by is missing.
> ---
> hw/block/nvme.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/block/nvme.c b/hw/block/nvme.c
> index 4b6d5e6..c6a6a0e 100644
> --- a/hw/block/nvme.c
> +++ b/hw/block/nvme.c
> @@ -154,6 +154,7 @@ static uint16_t nvme_dma_read_prp(NvmeCtrl *n, uint8_t *ptr, uint32_t len,
> qemu_sglist_destroy(&qsg);
> return NVME_INVALID_FIELD | NVME_DNR;
> }
> + qemu_sglist_destroy(&qsg);
> return NVME_SUCCESS;
> }
>
> --
> 1.8.5
>
>
>
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-06-19 12:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-19 6:27 [Qemu-devel] [PATCH] nvme: Fix memleak in nvme_dma_read_prp Ting Wang
2015-06-19 12:57 ` Stefan Hajnoczi [this message]
2015-06-19 14:54 ` Keith Busch
2015-06-22 9:58 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150619125727.GB18007@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=kathy.wangting@huawei.com \
--cc=keith.busch@intel.com \
--cc=lina.lulina@huawei.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).