From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58499)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Z5wPI-0003z1-Ti
	for qemu-devel@nongnu.org; Fri, 19 Jun 2015 09:32:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Z5wPI-0000xX-5K
	for qemu-devel@nongnu.org; Fri, 19 Jun 2015 09:32:32 -0400
Date: Fri, 19 Jun 2015 15:32:17 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20150619152936-mutt-send-email-mst@redhat.com>
References: <1433161230-29421-1-git-send-email-mst@redhat.com>
	<1433161230-29421-44-git-send-email-mst@redhat.com>
	<87h9q4tc4d.fsf@blackfin.pond.sub.org> <55841080.20501@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <55841080.20501@redhat.com>
Subject: Re: [Qemu-devel] [PULL v2 43/60] i386: drop FDC in pc-q35-2.4+ if
 neither it nor floppy drives are wanted
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laszlo Ersek <lersek@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Eduardo Habkost <ehabkost@redhat.com>, qemu-block@nongnu.org, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org, "Gabriel L. Somlo" <gsomlo@gmail.com>, Gerd Hoffmann <kraxel@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, John Snow <jsnow@redhat.com>, Richard Henderson <rth@twiddle.net>

On Fri, Jun 19, 2015 at 02:52:16PM +0200, Laszlo Ersek wrote:
> > Your merge is closer to a rewrite than to conflict resolution, rendering
> > my R-by totally meaningless.
> > 
> > In the future, please either fully test such a merge, or ask the
> > submitter / reviewers to review and test.
> 
> Yes, please. While I *was* Cc'd on this patch in the pull request, I
> didn't review it. I never expect PULLs to amount to such intrusive
> changes -- I treat them only as a hint that my patch is going in -- so
> if such changes are necessary (because the original patch doesn't apply
> any longer), then please ask me to rebase, or give me an explicit
> heads-up that my verification / testing is needed.
> 
> Thanks!
> Laszlo

Yes, this wasn't intentional. I don't really remember what went here,
sorry. Once thing we do need is a unit test for the floppy.
the easiest way to do it is probably by booting a guest,
using the bios tables test infrastructure.

-- 
MST