From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49277) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z6c4x-0008PW-Ky for qemu-devel@nongnu.org; Sun, 21 Jun 2015 06:02:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z6c4u-0005Sz-7E for qemu-devel@nongnu.org; Sun, 21 Jun 2015 06:02:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34763) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z6c4u-0005Sg-22 for qemu-devel@nongnu.org; Sun, 21 Jun 2015 06:02:16 -0400 Date: Sun, 21 Jun 2015 12:02:12 +0200 From: "Michael S. Tsirkin" Message-ID: <20150621120200-mutt-send-email-mst@redhat.com> References: <1433820378-8336-1-git-send-email-zhaoshenglong@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433820378-8336-1-git-send-email-zhaoshenglong@huawei.com> Subject: Re: [Qemu-devel] [PATCH] hw/arm/virt-acpi-build: Fix table revision and some comments List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Shannon Zhao Cc: peter.maydell@linaro.org, shannon.zhao@linaro.org, qemu-devel@nongnu.org, imammedo@redhat.com On Tue, Jun 09, 2015 at 11:26:18AM +0800, Shannon Zhao wrote: > From: Shannon Zhao > > The table revision is not the ACPI spec version. Fix the wrong revision > and also some comments. > > Signed-off-by: Shannon Zhao Reviewed-by: Michael S. Tsirkin > --- > hw/arm/virt-acpi-build.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c > index a9373cc..a036a00 100644 > --- a/hw/arm/virt-acpi-build.c > +++ b/hw/arm/virt-acpi-build.c > @@ -349,7 +349,7 @@ build_mcfg(GArray *table_data, GArray *linker, VirtGuestInfo *guest_info) > mcfg->allocation[0].end_bus_number = (memmap[VIRT_PCIE_ECAM].size > / PCIE_MMCFG_SIZE_MIN) - 1; > > - build_header(linker, table_data, (void *)mcfg, "MCFG", len, 5); > + build_header(linker, table_data, (void *)mcfg, "MCFG", len, 1); > } > > /* GTDT */ > @@ -375,7 +375,7 @@ build_gtdt(GArray *table_data, GArray *linker) > > build_header(linker, table_data, > (void *)(table_data->data + gtdt_start), "GTDT", > - table_data->len - gtdt_start, 5); > + table_data->len - gtdt_start, 2); > } > > /* MADT */ > @@ -412,7 +412,7 @@ build_madt(GArray *table_data, GArray *linker, VirtGuestInfo *guest_info, > > build_header(linker, table_data, > (void *)(table_data->data + madt_start), "APIC", > - table_data->len - madt_start, 5); > + table_data->len - madt_start, 3); > } > > /* FADT */ > @@ -469,7 +469,7 @@ build_dsdt(GArray *table_data, GArray *linker, VirtGuestInfo *guest_info) > g_array_append_vals(table_data, dsdt->buf->data, dsdt->buf->len); > build_header(linker, table_data, > (void *)(table_data->data + table_data->len - dsdt->buf->len), > - "DSDT", dsdt->buf->len, 5); > + "DSDT", dsdt->buf->len, 2); > free_aml_allocator(); > } > > @@ -507,6 +507,7 @@ void virt_acpi_build(VirtGuestInfo *guest_info, AcpiBuildTables *tables) > * FADT > * GTDT > * MADT > + * MCFG > * DSDT > */ > > @@ -514,7 +515,7 @@ void virt_acpi_build(VirtGuestInfo *guest_info, AcpiBuildTables *tables) > dsdt = tables_blob->len; > build_dsdt(tables_blob, tables->linker, guest_info); > > - /* FADT MADT GTDT pointed to by RSDT */ > + /* FADT MADT GTDT MCFG pointed to by RSDT */ > acpi_add_table(table_offsets, tables_blob); > build_fadt(tables_blob, tables->linker, dsdt); > > -- > 2.0.4 >