From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50266) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z6c9s-00025V-Pn for qemu-devel@nongnu.org; Sun, 21 Jun 2015 06:07:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z6c9p-0007Uz-FT for qemu-devel@nongnu.org; Sun, 21 Jun 2015 06:07:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39830) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z6c9p-0007Ur-A2 for qemu-devel@nongnu.org; Sun, 21 Jun 2015 06:07:21 -0400 Date: Sun, 21 Jun 2015 12:07:18 +0200 From: "Michael S. Tsirkin" Message-ID: <20150621120520-mutt-send-email-mst@redhat.com> References: <1433820713-78869-1-git-send-email-imammedo@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] pc: cleanup and convert TMP ACPI device description to AML API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Berger Cc: Igor Mammedov , qemu-devel@nongnu.org On Tue, Jun 09, 2015 at 06:40:48AM -0400, Stefan Berger wrote: > > + > > + if (misc->tpm_version != TPM_VERSION_UNSPEC) { > > + dev = aml_device("ISA.TPM"); > > + aml_append(dev, aml_name_decl("_HID", > > aml_eisaid("PNP0C31"))); > > + aml_append(dev, aml_name_decl("_STA", aml_int(0xF))); > > + crs = aml_resource_template(); > > + aml_append(crs, aml_memory32_fixed(TPM_TIS_ADDR_BASE, > > + TPM_TIS_ADDR_SIZE, AML_READ_WRITE)); > > + aml_append(crs, aml_irq_no_flags(TPM_TIS_IRQ)); > > + aml_append(dev, aml_name_decl("_CRS", crs)); > > + aml_append(scope, dev); > > + } > > + > > aml_append(sb_scope, scope); > > Once we add the _DSM to it from the link below, it will become longer and maybe > also more complicated. So I would put it into its own function already? > http://lists.nongnu.org/archive/html/qemu-devel/2015-05/msg05353.html > > My preference would be to wait until that _DSM has been added to it. > That would make Igor do even more work rewriting code from ASL to C. This patch shows C isn't harder than DSL so I don't think we can justify doing the work twice. I'll apply this as-is for now. -- MST