* [Qemu-devel] [PATCH] nvme: Fix memleak in nvme_dma_read_prp
@ 2015-06-19 6:27 Ting Wang
2015-06-19 12:57 ` Stefan Hajnoczi
2015-06-22 9:58 ` Stefan Hajnoczi
0 siblings, 2 replies; 4+ messages in thread
From: Ting Wang @ 2015-06-19 6:27 UTC (permalink / raw)
To: qemu-devel; +Cc: Lu Lina
From: Lu Lina <lina.lulina@huawei.com>
Signed-off-by: Lu Lina <lina.lulina@huawei.com>
---
hw/block/nvme.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 4b6d5e6..c6a6a0e 100644
--- a/hw/block/nvme.c
+++ b/hw/block/nvme.c
@@ -154,6 +154,7 @@ static uint16_t nvme_dma_read_prp(NvmeCtrl *n, uint8_t *ptr, uint32_t len,
qemu_sglist_destroy(&qsg);
return NVME_INVALID_FIELD | NVME_DNR;
}
+ qemu_sglist_destroy(&qsg);
return NVME_SUCCESS;
}
--
1.8.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] nvme: Fix memleak in nvme_dma_read_prp
2015-06-19 6:27 [Qemu-devel] [PATCH] nvme: Fix memleak in nvme_dma_read_prp Ting Wang
@ 2015-06-19 12:57 ` Stefan Hajnoczi
2015-06-19 14:54 ` Keith Busch
2015-06-22 9:58 ` Stefan Hajnoczi
1 sibling, 1 reply; 4+ messages in thread
From: Stefan Hajnoczi @ 2015-06-19 12:57 UTC (permalink / raw)
To: Ting Wang; +Cc: Keith Busch, Lu Lina, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 961 bytes --]
On Fri, Jun 19, 2015 at 02:27:34PM +0800, Ting Wang wrote:
Please CC the maintainer of this source file:
$ scripts/get_maintainer.pl -f hw/block/nvme.c
Keith Busch <keith.busch@intel.com> (supporter:nvme)
Kevin Wolf <kwolf@redhat.com> (supporter:Block layer core)
qemu-block@nongnu.org (open list:nvme)
> From: Lu Lina <lina.lulina@huawei.com>
>
> Signed-off-by: Lu Lina <lina.lulina@huawei.com>
Your Signed-off-by is missing.
> ---
> hw/block/nvme.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/block/nvme.c b/hw/block/nvme.c
> index 4b6d5e6..c6a6a0e 100644
> --- a/hw/block/nvme.c
> +++ b/hw/block/nvme.c
> @@ -154,6 +154,7 @@ static uint16_t nvme_dma_read_prp(NvmeCtrl *n, uint8_t *ptr, uint32_t len,
> qemu_sglist_destroy(&qsg);
> return NVME_INVALID_FIELD | NVME_DNR;
> }
> + qemu_sglist_destroy(&qsg);
> return NVME_SUCCESS;
> }
>
> --
> 1.8.5
>
>
>
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] nvme: Fix memleak in nvme_dma_read_prp
2015-06-19 12:57 ` Stefan Hajnoczi
@ 2015-06-19 14:54 ` Keith Busch
0 siblings, 0 replies; 4+ messages in thread
From: Keith Busch @ 2015-06-19 14:54 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: Keith Busch, Lu Lina, qemu-devel, Ting Wang
On Fri, 19 Jun 2015, Stefan Hajnoczi wrote:
>> From: Lu Lina <lina.lulina@huawei.com>
>>
>> Signed-off-by: Lu Lina <lina.lulina@huawei.com>
Thanks for the fix.
Acked-by: Keith Busch <keith.busch@intel.com>
>> @@ -154,6 +154,7 @@ static uint16_t nvme_dma_read_prp(NvmeCtrl *n, uint8_t *ptr, uint32_t len,
>> qemu_sglist_destroy(&qsg);
>> return NVME_INVALID_FIELD | NVME_DNR;
>> }
>> + qemu_sglist_destroy(&qsg);
>> return NVME_SUCCESS;
>> }
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] nvme: Fix memleak in nvme_dma_read_prp
2015-06-19 6:27 [Qemu-devel] [PATCH] nvme: Fix memleak in nvme_dma_read_prp Ting Wang
2015-06-19 12:57 ` Stefan Hajnoczi
@ 2015-06-22 9:58 ` Stefan Hajnoczi
1 sibling, 0 replies; 4+ messages in thread
From: Stefan Hajnoczi @ 2015-06-22 9:58 UTC (permalink / raw)
To: Ting Wang; +Cc: Lu Lina, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 320 bytes --]
On Fri, Jun 19, 2015 at 02:27:34PM +0800, Ting Wang wrote:
> From: Lu Lina <lina.lulina@huawei.com>
>
> Signed-off-by: Lu Lina <lina.lulina@huawei.com>
> ---
> hw/block/nvme.c | 1 +
> 1 file changed, 1 insertion(+)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-06-22 9:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-19 6:27 [Qemu-devel] [PATCH] nvme: Fix memleak in nvme_dma_read_prp Ting Wang
2015-06-19 12:57 ` Stefan Hajnoczi
2015-06-19 14:54 ` Keith Busch
2015-06-22 9:58 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).