From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43623) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z6zAq-0006OZ-RG for qemu-devel@nongnu.org; Mon, 22 Jun 2015 06:41:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z6zAn-0005kj-CV for qemu-devel@nongnu.org; Mon, 22 Jun 2015 06:41:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36111) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z6zAn-0005kW-6w for qemu-devel@nongnu.org; Mon, 22 Jun 2015 06:41:53 -0400 Date: Mon, 22 Jun 2015 12:41:48 +0200 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Message-ID: <20150622104147.GA26985@potion.redhat.com> References: <1434712840-14373-1-git-send-email-rkrcmar@redhat.com> <20150619155248.GP3874@thinpad.lan.raisama.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150619155248.GP3874@thinpad.lan.raisama.net> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2] target-i386: emulate CPUID level of real hardware List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: pbonzini@redhat.com, bsd@redhat.com, qemu-devel@nongnu.org, rth@twiddle.net 2015-06-19 12:52-0300, Eduardo Habkost: > On Fri, Jun 19, 2015 at 01:20:40PM +0200, Radim Kr=C4=8Dm=C3=A1=C5=99 w= rote: > [...] > > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c > > @@ -307,6 +307,24 @@ static void pc_init1(MachineState *machine) > > static void pc_compat_2_3(MachineState *machine) > > { > > savevm_skip_section_footers(); > > + > > + x86_cpu_compat_set_level("qemu64", 4); | [...] > > + > > + x86_cpu_compat_set_xlevel("n270", 0x8000000a); | [...] >=20 > We can simply use set the "level" and "xlevel" properties on > PC_COMPAT_2_3, we don't need the x86_cpu_compat_set_*level() functions. Oops, thanks, I will convert the code and send v3.