From: Stefan Hajnoczi <stefanha@gmail.com>
To: Shmulik Ladkani <shmulik.ladkani@gmail.com>
Cc: Jason Wang <jasowang@redhat.com>,
idan.brown@ravellosystems.com, qemu-devel@nongnu.org,
Stefan Hajnoczi <stefanha@redhat.com>,
Shmulik Ladkani <shmulik.ladkani@ravellosystems.com>
Subject: Re: [Qemu-devel] [PATCH] net: Allow specifying maximum number of network NICs during configure
Date: Mon, 22 Jun 2015 13:13:20 +0100 [thread overview]
Message-ID: <20150622121320.GG20966@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1434799589-27171-1-git-send-email-shmulik.ladkani@ravellosystems.com>
[-- Attachment #1: Type: text/plain, Size: 841 bytes --]
On Sat, Jun 20, 2015 at 02:26:29PM +0300, Shmulik Ladkani wrote:
> Currently, MAX_NICS is hardcoded as 8.
>
> Add a configuration option '--net-max-nics' so one can override the
> default.
> Unless specified, default value is kept as 8.
>
> Signed-off-by: Shmulik Ladkani <shmulik.ladkani@ravellosystems.com>
> ---
> configure | 7 +++++++
> include/net/net.h | 2 +-
> 2 files changed, 8 insertions(+), 1 deletion(-)
The -device e1000,netdev=tap0,id=e1000-nic0 syntax is preferred to -net
nic syntax and does not have the 8 NIC limit.
Please use the -device syntax instead of -net. Emulated NICs that
support virtio_net_hdr offload also perform better with the -device
syntax because -net nic does not allow virtio_net_hdr offloads.
If you think this patch should be merged, please explain the use case.
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-06-22 12:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-20 11:26 [Qemu-devel] [PATCH] net: Allow specifying maximum number of network NICs during configure Shmulik Ladkani
2015-06-22 12:13 ` Stefan Hajnoczi [this message]
2015-06-22 14:42 ` Shmulik Ladkani
2015-09-28 11:52 ` [Qemu-devel] Problems on vlan-based vnics! cauchy-love
2015-09-29 3:19 ` Jason Wang
2015-09-29 5:28 ` cauchy-love
2015-09-29 5:36 ` cauchy-love
2015-09-29 11:46 ` cauchy-love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150622121320.GG20966@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=idan.brown@ravellosystems.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=shmulik.ladkani@gmail.com \
--cc=shmulik.ladkani@ravellosystems.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).