From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41204) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z70bR-0000bU-2o for qemu-devel@nongnu.org; Mon, 22 Jun 2015 08:13:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z70bM-0003VN-05 for qemu-devel@nongnu.org; Mon, 22 Jun 2015 08:13:29 -0400 Received: from mail-wi0-x236.google.com ([2a00:1450:400c:c05::236]:35858) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z70bL-0003VF-NO for qemu-devel@nongnu.org; Mon, 22 Jun 2015 08:13:23 -0400 Received: by wicnd19 with SMTP id nd19so74661420wic.1 for ; Mon, 22 Jun 2015 05:13:23 -0700 (PDT) Date: Mon, 22 Jun 2015 13:13:20 +0100 From: Stefan Hajnoczi Message-ID: <20150622121320.GG20966@stefanha-thinkpad.redhat.com> References: <1434799589-27171-1-git-send-email-shmulik.ladkani@ravellosystems.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tvOENZuN7d6HfOWU" Content-Disposition: inline In-Reply-To: <1434799589-27171-1-git-send-email-shmulik.ladkani@ravellosystems.com> Subject: Re: [Qemu-devel] [PATCH] net: Allow specifying maximum number of network NICs during configure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Shmulik Ladkani Cc: Jason Wang , idan.brown@ravellosystems.com, qemu-devel@nongnu.org, Stefan Hajnoczi , Shmulik Ladkani --tvOENZuN7d6HfOWU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jun 20, 2015 at 02:26:29PM +0300, Shmulik Ladkani wrote: > Currently, MAX_NICS is hardcoded as 8. >=20 > Add a configuration option '--net-max-nics' so one can override the > default. > Unless specified, default value is kept as 8. >=20 > Signed-off-by: Shmulik Ladkani > --- > configure | 7 +++++++ > include/net/net.h | 2 +- > 2 files changed, 8 insertions(+), 1 deletion(-) The -device e1000,netdev=3Dtap0,id=3De1000-nic0 syntax is preferred to -net nic syntax and does not have the 8 NIC limit. Please use the -device syntax instead of -net. Emulated NICs that support virtio_net_hdr offload also perform better with the -device syntax because -net nic does not allow virtio_net_hdr offloads. If you think this patch should be merged, please explain the use case. --tvOENZuN7d6HfOWU Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVh/vgAAoJEJykq7OBq3PIfpEH/2IBLBilIMZ6lEDDOJwK/ifJ IP+WWQUJkX/W3wMoIaBaSR1wmpOeo/t7TpBkdQqzZ2qYCZB8DDoOx8JV1UELUrjN T2MO5z8+IJslhXbNytlG5Dp7t+8xwQcQHA/r42BnB/Vimr/bk1eleFONqup2NOvp i5FZ2R0NO7RbBT4KF+v4Emdsr4QOz+ojhLNd3KMk7JRB53/eOdlVI7owlrV3vXdu tBH7kbE9dlmu+Gma9wj4RtlEbBvFWfl1WNk6TlZKcIxtHxFPS0SVBg37Bi97mc// 6uRXNSwJM2T4qBkwx/DuSePheXXhnLA5ge/g5J/Gbb0OpYlKXhgDq+guYnGCl1s= =fh5v -----END PGP SIGNATURE----- --tvOENZuN7d6HfOWU--