From: Stefan Hajnoczi <stefanha@gmail.com>
To: Dimitris Aragiorgis <dimara@arrikto.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-block@nongnu.org,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v4 5/5] raw-posix: Introduce hdev_is_sg()
Date: Mon, 22 Jun 2015 13:33:06 +0100 [thread overview]
Message-ID: <20150622123306.GA783@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <20150622101843.GA16825@arr>
[-- Attachment #1: Type: text/plain, Size: 531 bytes --]
On Mon, Jun 22, 2015 at 01:18:43PM +0300, Dimitris Aragiorgis wrote:
> So I suggest we go with the submitted patch taking into account Eric's
> proposal: The code first stat()s the given filename to ensure it is a
> character device node, and then it issues the SG_GET_VERSION_NUM and
> SG_GET_SCSI_ID ioctl()s.
That's fine.
Regarding Eric's comment about ioctl number collisions, I've checked
Linux Documentation/ioctl/ioctl-number.txt. At least under Linux there
is no collision for SG_GET_VERSION_NUM/SG_GET_SCSI_ID.
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-06-22 12:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 9:57 [Qemu-devel] [PATCH v4 0/5] Some fixes related to scsi-generic Dimitris Aragiorgis
2015-05-20 9:57 ` [Qemu-devel] [PATCH v4 1/5] block: Use bdrv_is_sg() everywhere Dimitris Aragiorgis
2015-06-19 12:18 ` Stefan Hajnoczi
2015-05-20 9:57 ` [Qemu-devel] [PATCH v4 2/5] Fix migration in case of scsi-generic Dimitris Aragiorgis
2015-06-19 12:23 ` Stefan Hajnoczi
2015-05-20 9:57 ` [Qemu-devel] [PATCH v4 3/5] raw-posix: DPRINTF instead of DEBUG_BLOCK_PRINT Dimitris Aragiorgis
2015-06-18 20:05 ` Eric Blake
2015-06-19 12:25 ` Stefan Hajnoczi
2015-05-20 9:57 ` [Qemu-devel] [PATCH v4 4/5] raw-posix: Use DPRINTF for DEBUG_FLOPPY Dimitris Aragiorgis
2015-06-18 20:14 ` Eric Blake
2015-06-19 12:25 ` Stefan Hajnoczi
2015-05-20 9:57 ` [Qemu-devel] [PATCH v4 5/5] raw-posix: Introduce hdev_is_sg() Dimitris Aragiorgis
2015-06-18 20:16 ` Eric Blake
2015-06-19 12:33 ` Stefan Hajnoczi
2015-06-22 10:18 ` Dimitris Aragiorgis
2015-06-22 12:33 ` Stefan Hajnoczi [this message]
2015-05-29 5:15 ` [Qemu-devel] [PATCH v4 0/5] Some fixes related to scsi-generic Dimitris Aragiorgis
2015-06-18 11:07 ` Dimitris Aragiorgis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150622123306.GA783@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=dimara@arrikto.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).