From: Stefan Hajnoczi <stefanha@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 06/16] ahci: add ncq debug checks
Date: Mon, 22 Jun 2015 15:14:44 +0100 [thread overview]
Message-ID: <20150622141444.GC7136@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1434765047-29333-7-git-send-email-jsnow@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 538 bytes --]
On Fri, Jun 19, 2015 at 09:50:37PM -0400, John Snow wrote:
> @@ -1003,6 +1003,27 @@ static void process_ncq_command(AHCIState *s, int port, uint8_t *cmd_fis,
> (uint64_t)ncq_fis->lba0;
> ncq_tfs->tag = tag;
>
> +#ifdef DEBUG_AHCI
These sorts of debug ifdefs have a tendency to bitrot since the code
isn't compiled.
There is no need for the ifdef since DPRINTF() is deadcode when DEBUG_AHCI
is 0. The compiler parses the code, preventing bitrot, but optimizes
the code away when DEBUG_ACHI is 0.
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-06-22 14:14 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-20 1:50 [Qemu-devel] [PATCH 00/16] ahci: ncq cleanup, part 1 John Snow
2015-06-20 1:50 ` [Qemu-devel] [PATCH 01/16] ahci: Rename NCQFIS structure fields John Snow
2015-06-20 1:50 ` [Qemu-devel] [PATCH 02/16] ahci: use shorter variables John Snow
2015-06-20 1:50 ` [Qemu-devel] [PATCH 03/16] ahci: add ncq_err helper John Snow
2015-06-20 1:50 ` [Qemu-devel] [PATCH 04/16] ahci: check for ncq prdtl overflow John Snow
2015-06-22 14:06 ` Stefan Hajnoczi
2015-06-22 14:08 ` John Snow
2015-06-23 13:46 ` Stefan Hajnoczi
2015-06-23 15:55 ` John Snow
2015-06-22 14:16 ` Stefan Hajnoczi
2015-06-20 1:50 ` [Qemu-devel] [PATCH 05/16] ahci: separate prdtl from opts John Snow
2015-06-20 1:50 ` [Qemu-devel] [PATCH 06/16] ahci: add ncq debug checks John Snow
2015-06-22 14:14 ` Stefan Hajnoczi [this message]
2015-06-20 1:50 ` [Qemu-devel] [PATCH 07/16] ahci: ncq sector count correction John Snow
2015-06-20 1:50 ` [Qemu-devel] [PATCH 08/16] ahci: clear error register before NCQ cmd John Snow
2015-06-22 14:38 ` Stefan Hajnoczi
2015-06-22 14:43 ` John Snow
2015-06-22 21:51 ` John Snow
2015-06-23 13:49 ` Stefan Hajnoczi
2015-06-20 1:50 ` [Qemu-devel] [PATCH 09/16] libqos/ahci: fix cmd_sanity for ncq John Snow
2015-06-20 1:50 ` [Qemu-devel] [PATCH 10/16] libqos/ahci: add NCQ frame support John Snow
2015-06-20 1:50 ` [Qemu-devel] [PATCH 11/16] libqos/ahci: edit wait to be ncq aware John Snow
2015-06-20 1:50 ` [Qemu-devel] [PATCH 12/16] libqos/ahci: adjust expected NCQ interrupts John Snow
2015-06-20 1:50 ` [Qemu-devel] [PATCH 13/16] libqos/ahci: set the NCQ tag on command_commit John Snow
2015-06-20 1:50 ` [Qemu-devel] [PATCH 14/16] libqos/ahci: Force all NCQ commands to be LBA48 John Snow
2015-06-20 1:50 ` [Qemu-devel] [PATCH 15/16] qtest/ahci: simple ncq data test John Snow
2015-06-20 1:50 ` [Qemu-devel] [PATCH 16/16] qtest/ahci: ncq migration test John Snow
2015-06-20 2:08 ` John Snow
2015-06-22 14:56 ` [Qemu-devel] [PATCH 00/16] ahci: ncq cleanup, part 1 Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150622141444.GC7136@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).