From: Amit Shah <amit.shah@redhat.com>
To: arei.gonglei@huawei.com
Cc: qemu-trivial@nongnu.org, mrhines@us.ibm.com,
qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
quintela@redhat.com
Subject: Re: [Qemu-devel] [PATCH] rdma: fix memory leak
Date: Tue, 23 Jun 2015 09:42:51 +0530 [thread overview]
Message-ID: <20150623041251.GA2058@grmbl.mre> (raw)
In-Reply-To: <1435021348-9156-1-git-send-email-arei.gonglei@huawei.com>
On (Tue) 23 Jun 2015 [09:02:28], arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
>
> Variable "r" going out of scope leaks the storage
> it points to in line 3268.
Interestingly Dave posted a different patch for the same issue. I
prefer this approach.
Reviewed-by: Amit Shah <amit.shah@redhat.com>
Amit
next prev parent reply other threads:[~2015-06-23 4:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-23 1:02 [Qemu-devel] [PATCH] rdma: fix memory leak arei.gonglei
2015-06-23 4:12 ` Amit Shah [this message]
2015-06-23 7:36 ` Markus Armbruster
2015-06-23 9:20 ` Markus Armbruster
2015-06-23 9:32 ` Gonglei
2015-06-23 7:47 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150623041251.GA2058@grmbl.mre \
--to=amit.shah@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=dgilbert@redhat.com \
--cc=mrhines@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).