From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53169) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7H5N-0006zw-6G for qemu-devel@nongnu.org; Tue, 23 Jun 2015 01:49:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z7H5I-00061U-Kb for qemu-devel@nongnu.org; Tue, 23 Jun 2015 01:49:29 -0400 Date: Tue, 23 Jun 2015 15:49:05 +1000 From: David Gibson Message-ID: <20150623054905.GA13352@voom.redhat.com> References: <1434627456-13745-1-git-send-email-aik@ozlabs.ru> <1434627456-13745-3-git-send-email-aik@ozlabs.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Qj50iofY6VFoOw9j" Content-Disposition: inline In-Reply-To: <1434627456-13745-3-git-send-email-aik@ozlabs.ru> Subject: Re: [Qemu-devel] [PATCH qemu v8 02/14] vfio: spapr: Move SPAPR-related code to a separate file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: Alex Williamson , qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Gavin Shan , Alexander Graf --Qj50iofY6VFoOw9j Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 18, 2015 at 09:37:24PM +1000, Alexey Kardashevskiy wrote: > This moves SPAPR bits to a separate file to avoid pollution of x86 code. >=20 > This enables spapr-vfio on CONFIG_SOFTMMU (not CONFIG_PSERIES) as > the config options are only visible in makefiles and not in the source co= de > so there is no an obvious way of implementing stubs if hw/vfio/spapr.c is > not compiled. >=20 > This is a mechanical patch. >=20 > Signed-off-by: Alexey Kardashevskiy > Reviewed-by: David Gibson So, I sent a R-b for this earlier, and I think the patch won't break anything. But on consideration I don't really see the point of this. The parts that are split out into vfio/spapr.c aren't really spapr specific, just used a bit more heavily with the spapr model. That may not even remain the case if guest-visible x86 IOMMUs become more common. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --Qj50iofY6VFoOw9j Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJViPNRAAoJEGw4ysog2bOSYHIP/2tCCgi9kZaVnk5qOwVGtTpq FK9h82p/ZO2qgql+F5see4hl/i6PrC95aP2WPwuF4YsojDmzwmzsYUx5YUwIlChT AIFgWEi52RtxgxghJawPORE6WGbnJ8GKjR5bSgU4zpbLrYlRraRj1sP4b5TXJMtu KeWsfxSTR+KtuvpSnfNssEEbOMTTEahRAh0ma9zOJxI3t1Fk4VeRVf+jLFPmed+/ nH0LQ+DbbQ1HgBCsm2OglywSBxxREHGKvT8tx9vAIkjXdD6h3LdTLMAD7nlQLlmQ 4V4iNM9Mqh4z8dFUuIRWb/iFNy+rwUOA9xuvL7QyZ7j/dNYJhPbcBUgbfHprbaQg DHBPuwys+wj9Wi/6F4BkKRfCJHK8CDFAD37OmHifgKujklI8JOLd+z77ouC7rAzq aLNHR5gRh3JuNlG43veX+dYLYvEuOeNhuIRKwwjrbJW8bpDb9prmNB/clpvxXcMo 8CkfCWIVlmH6kJaN/WtjxjpO6lOf0yqUZTvWVMyJ7LrXbllQ8AqzUmoSnBtX1Dzd aM0gJ2KPkvstWH2myxmqGE0WYvGEQueNDB9IBfctQ0B/Qhro4pkqqt7e72ZVloTI out9KS+e8MAUjxuIkTH1depo75LbIb+bxTFPoABvurwF0M7IxdCHXOS8LkYjI8BB RvsiQZ2uHO9KOrmZELpX =LOIq -----END PGP SIGNATURE----- --Qj50iofY6VFoOw9j--