Re: [Qemu-devel] [Qemu-trivial] [PULL 00/21] Trivial patches for 2015-06-22

[Wolfgang Bumiller <w.bumiller@proxmox.com>]

> Fails to build on Windows:
> 
> util/qemu-sockets.c: In function ‘inet_parse_connect_opts’:
> util/qemu-sockets.c:338: error: ‘AI_V4MAPPED’ undeclared (first use in

What's the procedure with the trivial pull-request here now. Should I
send a v2 of this patch to trivial, or a fix based on the trivial
branch?
It's a bit embarrassing, I should have seen this coming, as there's
already an #ifdef for AI_ADDRCONFIG to #define it to 0. So the change
would just be doing the same for V4MAPPED.

Sorry about that.

On Mon, Jun 22, 2015 at 05:02:17PM +0100, Peter Maydell wrote:
> On 22 June 2015 at 12:16, Michael Tokarev <mjt@tls.msk.ru> wrote:
> > There are a few random thing here and there.  I especially
> > want to note 2 of them:
> >
> >  - QOMification series by Gonglei
> >  - rearrangement of ./configure --help output by me
> >
> > Other than that, the stuff is really trivial.
> >
> > Please consider applying/pulling.
> >
> > /mjt
> >
> > The following changes since commit ad7020a7e7b27d468ecc2aacb04ba4eb09017074:
> >
> >   target-microblaze: Remove dead code (2015-06-21 17:20:16 +1000)
> >
> > are available in the git repository at:
> >
> >   git://git.corpit.ru/qemu.git tags/pull-trivial-patches-2015-06-22
> >
> > for you to fetch changes up to 43ce995c79c09595e6fbdcabecd1c8b43cf9e4a4:
> >
> >   util/qemu-sockets: improve ai_flag hints for ipv6 hosts (2015-06-22 14:08:25 +0300)
> >
> > ----------------------------------------------------------------
> > trivial patches for 2015-06-22
> 
> Fails to build on Windows:
> 
> util/qemu-sockets.c: In function ‘inet_parse_connect_opts’:
> util/qemu-sockets.c:338: error: ‘AI_V4MAPPED’ undeclared (first use in
> this function)
> util/qemu-sockets.c:338: error: (Each undeclared identifier is
> reported only once
> util/qemu-sockets.c:338: error: for each function it appears in.)
> util/qemu-sockets.c: In function ‘inet_dgram_opts’:
> util/qemu-sockets.c:438: error: ‘AI_V4MAPPED’ undeclared (first use in
> this function)
> 
> (Also I had to resolve a conflict in configure, so if you rebase
> on current master you'll save me having to do it twice...)
> 
> thanks
> -- PMM
> 
>