From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39728)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Z7Hrv-0002PA-JS
	for qemu-devel@nongnu.org; Tue, 23 Jun 2015 02:39:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Z7Hrp-00058d-1L
	for qemu-devel@nongnu.org; Tue, 23 Jun 2015 02:39:39 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56940)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Z7Hro-00058N-Rx
	for qemu-devel@nongnu.org; Tue, 23 Jun 2015 02:39:32 -0400
Date: Tue, 23 Jun 2015 08:39:28 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20150623083302-mutt-send-email-mst@redhat.com>
References: <1432686576-14816-1-git-send-email-pcacjr@zytor.com>
	<1435014629-23576-1-git-send-email-pcacjr@zytor.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1435014629-23576-1-git-send-email-pcacjr@zytor.com>
Subject: Re: [Qemu-devel] [PATCH v5 1/3] ich9: add TCO interface emulation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paulo Alcantara <pcacjr@gmail.com>
Cc: pbonzini@redhat.com, seabios@seabios.org, Paulo Alcantara <pcacjr@zytor.com>, qemu-devel@nongnu.org, kraxel@redhat.com

On Mon, Jun 22, 2015 at 08:10:27PM -0300, Paulo Alcantara wrote:
> This interface provides some registers within a 32-byte range and can be
> acessed through PCI-to-LPC bridge interface (PMBASE + 0x60).
> 
> It's commonly used as a watchdog timer to detect system lockups through
> SMIs that are generated -- if TCO_EN bit is set -- on every timeout. If
> NO_REBOOT bit is not set in GCS (General Control and Status register),
> the system will be resetted upon second timeout if TCO_RLD register
> wasn't previously written to prevent timeout.
> 
> This patch adds support to TCO watchdog logic and few other features
> like mapping NMIs to SMIs (NMI2SMI_EN bit), system intruder detection,
> etc. are not implemented yet.
> 
> Signed-off-by: Paulo Alcantara <pcacjr@zytor.com>

One useful feature to implement could be ability to set the NO_REBOOT
strapping pin to 1. And maybe it's even a better default - will have
to experiment with this feature some more.
Does not have to block this patchset, can be done by a patch on top.

-- 
MST