From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60913)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Z7QLD-0008V6-70
	for qemu-devel@nongnu.org; Tue, 23 Jun 2015 11:42:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Z7QL7-000224-Jq
	for qemu-devel@nongnu.org; Tue, 23 Jun 2015 11:42:27 -0400
Received: from mx1.redhat.com ([209.132.183.28]:54862)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Z7QL7-00021w-78
	for qemu-devel@nongnu.org; Tue, 23 Jun 2015 11:42:21 -0400
Date: Tue, 23 Jun 2015 17:42:18 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20150623154217.GA15245@redhat.com>
References: <1433762257-1752411-1-git-send-email-stefanb@linux.vnet.ibm.com>
	<20150623135234.GA13199@redhat.com>
	<OFB0CE67E2.42FC98BE-ON85257E6D.0055B143-85257E6D.0055CAF8@us.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <OFB0CE67E2.42FC98BE-ON85257E6D.0055B143-85257E6D.0055CAF8@us.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v4 0/4] Extend TPM support with a
	QEMU-external TPM
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Berger <stefanb@us.ibm.com>
Cc: qemu-devel@nongnu.org, quan.xu@intel.com, Stefan Berger <stefanb@linux.vnet.ibm.com>

On Tue, Jun 23, 2015 at 11:37:02AM -0400, Stefan Berger wrote:
> "Michael S. Tsirkin" <mst@redhat.com> wrote on 06/23/2015 09:52:34 AM:
> 
> > From: "Michael S. Tsirkin" <mst@redhat.com>
> > To: Stefan Berger <stefanb@linux.vnet.ibm.com>
> > Cc: qemu-devel@nongnu.org, quan.xu@intel.com, Stefan Berger/Watson/IBM@IBMUS
> > Date: 06/23/2015 09:52 AM
> > Subject: Re: [PATCH v4 0/4] Extend TPM support with a QEMU-external TPM
> >
> > On Mon, Jun 08, 2015 at 07:17:33AM -0400, Stefan Berger wrote:
> > > The following series of patches extends TPM support with an
> > > external TPM that offers a Linux CUSE (character device in userspace)
> > > interface. This TPM lets each VM access its own private vTPM.
> > > The CUSE TPM supports suspend/resume and migration. Much
> > > out-of-band functionality necessary to control the CUSE TPM is
> > > implemented using ioctls.
> >
> > So the problem is really review. I feel to judge this
> > adequately I'd have to review cuse code too (since
> > no one else did). And unfortunately I don't have the
> > time to do this anytime soon.
> 
> You mean the CUSE code in the kernel and client library?

I mean swtpm in your tree.

> >
> > As far as I'm concerned, if anyone wants to review
> > and merge these patches, pls go ahead, I have nothing
> > against them.
> 
> Sounds good.
> 
>    Stefan
> 
> >
> > --
> > MST
> >