* [Qemu-devel] [PATCH] m68k: remove useless file m68k-qreg.h
@ 2015-06-24 0:07 Laurent Vivier
2015-06-24 0:19 ` Peter Crosthwaite
2015-06-24 19:12 ` Thomas Huth
0 siblings, 2 replies; 5+ messages in thread
From: Laurent Vivier @ 2015-06-24 0:07 UTC (permalink / raw)
To: qemu-devel; +Cc: Peter Maydell, Laurent Vivier
Unused since:
commit e1f3808e03f73e7a7fa966afbed2455dd052202e
Author: pbrook <pbrook@c046a42c-6fe2-441c-8c8c-71466251a162>
Date: Sat May 24 22:29:16 2008 +0000
Convert m68k target to TCG.
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
target-m68k/m68k-qreg.h | 11 -----------
1 file changed, 11 deletions(-)
delete mode 100644 target-m68k/m68k-qreg.h
diff --git a/target-m68k/m68k-qreg.h b/target-m68k/m68k-qreg.h
deleted file mode 100644
index c224d5e..0000000
--- a/target-m68k/m68k-qreg.h
+++ /dev/null
@@ -1,11 +0,0 @@
-enum {
-#define DEFO32(name, offset) QREG_##name,
-#define DEFR(name, reg, mode) QREG_##name,
-#define DEFF64(name, offset) QREG_##name,
- QREG_NULL,
-#include "qregs.def"
- TARGET_NUM_QREGS = 0x100
-#undef DEFO32
-#undef DEFR
-#undef DEFF64
-};
--
2.4.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] m68k: remove useless file m68k-qreg.h
2015-06-24 0:07 [Qemu-devel] [PATCH] m68k: remove useless file m68k-qreg.h Laurent Vivier
@ 2015-06-24 0:19 ` Peter Crosthwaite
2015-06-24 0:21 ` Laurent Vivier
2015-06-24 19:12 ` Thomas Huth
1 sibling, 1 reply; 5+ messages in thread
From: Peter Crosthwaite @ 2015-06-24 0:19 UTC (permalink / raw)
To: Laurent Vivier; +Cc: Peter Maydell, qemu-devel@nongnu.org Developers
On Tue, Jun 23, 2015 at 5:07 PM, Laurent Vivier <laurent@vivier.eu> wrote:
> Unused since:
>
> commit e1f3808e03f73e7a7fa966afbed2455dd052202e
> Author: pbrook <pbrook@c046a42c-6fe2-441c-8c8c-71466251a162>
> Date: Sat May 24 22:29:16 2008 +0000
>
> Convert m68k target to TCG.
>
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
You should cc qemu-trivial on dead-code deletions and the like. This
is also a patch queue in its own right so there is no need to identify
m68k owner for this.
Regards,
Peter
> ---
> target-m68k/m68k-qreg.h | 11 -----------
> 1 file changed, 11 deletions(-)
> delete mode 100644 target-m68k/m68k-qreg.h
>
> diff --git a/target-m68k/m68k-qreg.h b/target-m68k/m68k-qreg.h
> deleted file mode 100644
> index c224d5e..0000000
> --- a/target-m68k/m68k-qreg.h
> +++ /dev/null
> @@ -1,11 +0,0 @@
> -enum {
> -#define DEFO32(name, offset) QREG_##name,
> -#define DEFR(name, reg, mode) QREG_##name,
> -#define DEFF64(name, offset) QREG_##name,
> - QREG_NULL,
> -#include "qregs.def"
> - TARGET_NUM_QREGS = 0x100
> -#undef DEFO32
> -#undef DEFR
> -#undef DEFF64
> -};
> --
> 2.4.3
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] m68k: remove useless file m68k-qreg.h
2015-06-24 0:19 ` Peter Crosthwaite
@ 2015-06-24 0:21 ` Laurent Vivier
2015-06-24 0:23 ` Peter Crosthwaite
0 siblings, 1 reply; 5+ messages in thread
From: Laurent Vivier @ 2015-06-24 0:21 UTC (permalink / raw)
To: Peter Crosthwaite; +Cc: Peter Maydell, qemu-devel@nongnu.org Developers
Le 24/06/2015 02:19, Peter Crosthwaite a écrit :
> On Tue, Jun 23, 2015 at 5:07 PM, Laurent Vivier <laurent@vivier.eu> wrote:
>> Unused since:
>>
>> commit e1f3808e03f73e7a7fa966afbed2455dd052202e
>> Author: pbrook <pbrook@c046a42c-6fe2-441c-8c8c-71466251a162>
>> Date: Sat May 24 22:29:16 2008 +0000
>>
>> Convert m68k target to TCG.
>>
>> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
>
> You should cc qemu-trivial on dead-code deletions and the like. This
> is also a patch queue in its own right so there is no need to identify
> m68k owner for this.
OK, thank you. Should I resend them ?
Laurent
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] m68k: remove useless file m68k-qreg.h
2015-06-24 0:21 ` Laurent Vivier
@ 2015-06-24 0:23 ` Peter Crosthwaite
0 siblings, 0 replies; 5+ messages in thread
From: Peter Crosthwaite @ 2015-06-24 0:23 UTC (permalink / raw)
To: Laurent Vivier, qemu-trivial
Cc: Peter Maydell, qemu-devel@nongnu.org Developers
On Tue, Jun 23, 2015 at 5:21 PM, Laurent Vivier <laurent@vivier.eu> wrote:
>
>
> Le 24/06/2015 02:19, Peter Crosthwaite a écrit :
>> On Tue, Jun 23, 2015 at 5:07 PM, Laurent Vivier <laurent@vivier.eu> wrote:
>>> Unused since:
>>>
>>> commit e1f3808e03f73e7a7fa966afbed2455dd052202e
>>> Author: pbrook <pbrook@c046a42c-6fe2-441c-8c8c-71466251a162>
>>> Date: Sat May 24 22:29:16 2008 +0000
>>>
>>> Convert m68k target to TCG.
>>>
>>> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
>>
>> You should cc qemu-trivial on dead-code deletions and the like. This
>> is also a patch queue in its own right so there is no need to identify
>> m68k owner for this.
>
> OK, thank you. Should I resend them ?
>
No should be ok, I think the maintainer can handle it via
after-the-fact CCs. I have ccd this one just now.
Regards,
Peter
> Laurent
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] m68k: remove useless file m68k-qreg.h
2015-06-24 0:07 [Qemu-devel] [PATCH] m68k: remove useless file m68k-qreg.h Laurent Vivier
2015-06-24 0:19 ` Peter Crosthwaite
@ 2015-06-24 19:12 ` Thomas Huth
1 sibling, 0 replies; 5+ messages in thread
From: Thomas Huth @ 2015-06-24 19:12 UTC (permalink / raw)
To: Laurent Vivier, qemu-devel; +Cc: qemu-trivial, Peter Maydell
On Wed, 24 Jun 2015 02:07:24 +0200
Laurent Vivier <laurent@vivier.eu> wrote:
> Unused since:
>
> commit e1f3808e03f73e7a7fa966afbed2455dd052202e
> Author: pbrook <pbrook@c046a42c-6fe2-441c-8c8c-71466251a162>
> Date: Sat May 24 22:29:16 2008 +0000
>
> Convert m68k target to TCG.
>
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---
> target-m68k/m68k-qreg.h | 11 -----------
> 1 file changed, 11 deletions(-)
> delete mode 100644 target-m68k/m68k-qreg.h
>
> diff --git a/target-m68k/m68k-qreg.h b/target-m68k/m68k-qreg.h
> deleted file mode 100644
> index c224d5e..0000000
> --- a/target-m68k/m68k-qreg.h
> +++ /dev/null
> @@ -1,11 +0,0 @@
> -enum {
> -#define DEFO32(name, offset) QREG_##name,
> -#define DEFR(name, reg, mode) QREG_##name,
> -#define DEFF64(name, offset) QREG_##name,
> - QREG_NULL,
> -#include "qregs.def"
> - TARGET_NUM_QREGS = 0x100
> -#undef DEFO32
> -#undef DEFR
> -#undef DEFF64
> -};
Reviewed-by: Thomas Huth <huth@tuxfamily.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-06-24 19:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-24 0:07 [Qemu-devel] [PATCH] m68k: remove useless file m68k-qreg.h Laurent Vivier
2015-06-24 0:19 ` Peter Crosthwaite
2015-06-24 0:21 ` Laurent Vivier
2015-06-24 0:23 ` Peter Crosthwaite
2015-06-24 19:12 ` Thomas Huth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).