From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59956)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1Z84t7-0007T0-Pj
	for qemu-devel@nongnu.org; Thu, 25 Jun 2015 07:00:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1Z84t1-00007g-RF
	for qemu-devel@nongnu.org; Thu, 25 Jun 2015 07:00:09 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59049)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1Z84t1-00006x-Mx
	for qemu-devel@nongnu.org; Thu, 25 Jun 2015 07:00:03 -0400
Date: Thu, 25 Jun 2015 18:59:59 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20150625105959.GE12846@ad.nay.redhat.com>
References: <1435163110-2724-1-git-send-email-pbonzini@redhat.com>
	<1435163110-2724-4-git-send-email-pbonzini@redhat.com>
	<20150625034457.GH17695@ad.nay.redhat.com>
	<558BB1CA.3030006@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <558BB1CA.3030006@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/9] memory: Add global-locking property to
	memory regions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: borntraeger@de.ibm.com, Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Frederic Konrad <fred.konrad@greensocs.com>

On Thu, 06/25 09:46, Paolo Bonzini wrote:
> 
> 
> On 25/06/2015 05:44, Fam Zheng wrote:
> >> > + * memory_region_clear_global_locking: Declares that access processing does
> >> > + *                                     not depend on the QEMU global lock.
> >> > + *
> >> > + * By clearing this property, accesses to the memory region will be processed
> > Inconsistent with singlar form (access) in the previous one. Otherwise,
> 
> I think this is correct English actually.  "Access processing" in the
> first line cannot use a plural because it behaves as a single word.
> Let's ask a native speaker. :)

I meant the above "When this is invoked, access to this memory regions will be
processed..." compared to this "accesses to the memory region".

Fam