From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38982) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z86aZ-0003kG-7J for qemu-devel@nongnu.org; Thu, 25 Jun 2015 08:49:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z86aV-0002zZ-Vc for qemu-devel@nongnu.org; Thu, 25 Jun 2015 08:49:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42353) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z86aV-0002yg-Qf for qemu-devel@nongnu.org; Thu, 25 Jun 2015 08:49:03 -0400 Date: Thu, 25 Jun 2015 14:49:00 +0200 From: "Michael S. Tsirkin" Message-ID: <20150625124900.GA2968@redhat.com> References: <1435058256-11838-1-git-send-email-cornelia.huck@de.ibm.com> <20150623183634.14c9d81e@thh440s> <20150623191939.109e0c5c.cornelia.huck@de.ibm.com> <20150625122440.779fe690.cornelia.huck@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150625122440.779fe690.cornelia.huck@de.ibm.com> Subject: Re: [Qemu-devel] [PATCH 0/4] virtio-ccw: virtio-1 enablement List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: Thomas Huth , qemu-devel@nongnu.org On Thu, Jun 25, 2015 at 12:24:40PM +0200, Cornelia Huck wrote: > On Tue, 23 Jun 2015 19:19:39 +0200 > Cornelia Huck wrote: > > > On Tue, 23 Jun 2015 18:36:34 +0200 > > Thomas Huth wrote: > > > > > On Tue, 23 Jun 2015 13:17:32 +0200 > > > Cornelia Huck wrote: > > > > > > > Michael, > > > > > > > > here's the virtio-ccw patches that Gerd had dropped due to conflicts > > > > during his virtio-1 rebase. Patch 2 has been updated with my changes > > > > to ensure big endian accesses (which was a separate patch before). > > > > > > > > There might be more patches that were in my tree but are not yet upstream, > > > > but I'm still digging myself out from under the post-vacation email pile. > > > > > > > > I think these can still go into 2.4. > > > > > > Is it safe enough to enable them by default already? If I've got > > > the virtio-pci code right (see the patch description at > > > https://lists.gnu.org/archive/html/qemu-devel/2015-06/msg01362.html), > > > it is still disabled there by default - and "modern will be turned on by > > > default once all remaining spec compilance issues are addressed". > > > > I was about to say "yes" when I noticed that we probably want to care > > about migrating dev->revision as well... I'll drop patch 4 for now and > > just send patches 1-3 from this series. > > On a second thought, I can simply include dev->revision, as we have the > incompatible ->config_vector change for this release already. I'll > include a new patch for this and patch 4 as well, as we only need to > care about Linux guests on ccw for now and those are fine. I don't think enable by default is a good idea for 2.4 since I think we have spec compliance issues which just don't trigger with linux guests. For example, devices poke at rings before DRIVER_OK is set. If we release QEMU like this, guests will have to work around these issues, which is not nice. Let's release 2.4 in disabled by default mode, and flip it around for 2.5. -- MST