From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34786) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z8ML7-0008IV-Pr for qemu-devel@nongnu.org; Fri, 26 Jun 2015 01:38:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z8ML4-0002oF-NI for qemu-devel@nongnu.org; Fri, 26 Jun 2015 01:38:13 -0400 Received: from ozlabs.org ([103.22.144.67]:59473) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z8ML4-0002mt-CV for qemu-devel@nongnu.org; Fri, 26 Jun 2015 01:38:10 -0400 Date: Fri, 26 Jun 2015 15:09:06 +1000 From: David Gibson Message-ID: <20150626050906.GC22479@voom.redhat.com> References: <1435291564-14014-1-git-send-email-bharata@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="4jXrM3lyYWu4nBt5" Content-Disposition: inline In-Reply-To: <1435291564-14014-1-git-send-email-bharata@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v3 0/5] Refactoring pc_dimm_plug and NUMA node lookup API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bharata B Rao Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, ehabkost@redhat.com, imammedo@redhat.com --4jXrM3lyYWu4nBt5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 26, 2015 at 09:35:59AM +0530, Bharata B Rao wrote: > Hi, >=20 > Here is the v3 of the patchset that refactors pc_dimm_plug and adds > an API to lookup NUMA node by address. >=20 > - Refactoring pc_dimm_plug() helps other architectures like PowerPC > to make use of common code. > - API to lookup NUMA node id by address is required to support memory > hotplug on PowerPC sPAPR guests. >=20 > The patchset that adds memory hotplug support to PowerPC sPAPR that > was posted at > http://lists.nongnu.org/archive/html/qemu-devel/2015-06/msg06574.html > depends on this patchset. >=20 > Changes in v3: > ------------- > - Not calling pc_dimm_memory_unplug() when pc_dimm_memory_plug() fails > because when pc_dimm_memory_plug() fails, it wouldn't have done > memory_region_add_subregion() and vmstate_register_ram(). > - As per Igor's suggestion, moving of hotplug related fields from > PCMachineState is now in a separate patch. >=20 > v2: https://lists.gnu.org/archive/html/qemu-devel/2015-06/msg05157.html > v1: https://lists.gnu.org/archive/html/qemu-devel/2015-06/msg03212.html > v0: https://lists.gnu.org/archive/html/qemu-devel/2015-05/msg01078.html >=20 > Bharata B Rao (5): > pc,pc-dimm: Extract hotplug related fields in PCMachineState to a > structure > pc,pc-dimm: Factor out reusable parts in pc_dimm_plug to a separate > routine > numa,pc-dimm: Store pc-dimm memory information in numa_info > numa: Store boot memory address range in node_info > numa: API to lookup NUMA node by address >=20 > hw/i386/acpi-build.c | 2 +- > hw/i386/pc.c | 84 +++++++++---------------------------------= ------ > hw/mem/pc-dimm.c | 84 ++++++++++++++++++++++++++++++++++++++++++= ++++++ > include/hw/i386/pc.h | 7 ++-- > include/hw/mem/pc-dimm.h | 15 +++++++++ > include/sysemu/numa.h | 11 +++++++ > numa.c | 77 ++++++++++++++++++++++++++++++++++++++++++= ++ > 7 files changed, 205 insertions(+), 75 deletions(-) Looks good to me. I'm hoping this can be merged pretty soon, so I can then pull the actual pseries hotplug memory stuff into spapr-next. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --4jXrM3lyYWu4nBt5 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVjN5yAAoJEGw4ysog2bOSEhQQAOW8DmZZM8ZSrxw5zsOOGGKa 4gxGEpeNeMAq2UeTbjgnTRe0BsaShf1RmXciGuKq55wJ4dkjgjykCOlgNknTbXXV 1I79P/ALFjntT+Rq8N+xhD53wQWC4TP0XB3Pul9b/T9Rsb0A2F2v9XODuh2aqCV2 vEqDgfk9G3wTbe9Rgaqwj5gmK6oD4Qot0DwsOBUIqyMp/csY+dP8gOZQPD17oWzc aeXNtSo6OdtwJgKmLjnx+nLs9kwoWnpBWxnnLcjOgX4UANZ+8GoZz3BPcPNh8mZH oe11pSjkIl+zOlZs/pXKpW52Zjrite/Y8cvSX2tBE9ekPKwlYKQQ3bOjw/vulYTF PN8pwC4qFarKa4+IEZqfXy22+f2JCqjIhZXQywk3DZtfbN6X5YMGhRnqMAxu/aYd PlpAMUPYNvlesu/K3bFZFfDREHd3XZH7c70FTwFBxlBsHnqcpOaBsmUl6AcJ8UnR fgCcBoTzXoa7NfitbqEbMJuAVPnfgsG4/1yZuzaztCSWmqjh6JA3/fyFfOjKGw/N XdYqm6S+9TsvKRNwuWhPj7IseuhgcJEYhhcycPfzIxBMN9GBd4zppOr9KQ7k5alF NKjoaz0XeNo3eQY1bt/hiMyDLGGCyypH8yxx/PDR4sC6y/QtNVfqqFw59emRf5wo nFzSGnc6EXbz5iNbtPIv =Ybwo -----END PGP SIGNATURE----- --4jXrM3lyYWu4nBt5--