qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Bharata B Rao <bharata@linux.vnet.ibm.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: mdroth@linux.vnet.ibm.com, aik@ozlabs.ru, agraf@suse.de,
	qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
	tyreld@linux.vnet.ibm.com, nfont@linux.vnet.ibm.com,
	imammedo@redhat.com
Subject: Re: [Qemu-devel] [RFC PATCH v5 6/6] spapr: Don't allow memory hotplug to memory less nodes
Date: Fri, 26 Jun 2015 11:13:14 +0530	[thread overview]
Message-ID: <20150626054314.GE5569@in.ibm.com> (raw)
In-Reply-To: <20150626053329.GD22737@voom.redhat.com>

On Fri, Jun 26, 2015 at 03:33:29PM +1000, David Gibson wrote:
> On Thu, Jun 25, 2015 at 11:44:15AM +0530, Bharata B Rao wrote:
> > Currently PowerPC kernel doesn't allow hot-adding memory to memory-less
> > node, but instead will silently add the memory to the first node that has
> > some memory. This causes two unexpected behaviours for the user.
> > 
> > Memory gets hotplugged to a different node than what the user specified.
> > Since pc-dimm subsystem in QEMU still thinks that memory belongs to
> > memory-less node, a reboot will set things accordingly and the previously
> > hotplugged memory now ends in the right node. This appears as if some
> > memory moved from one node to another.
> > 
> > So until kernel starts supporting memory hotplug to memory-less
> > nodes, just prevent such attempts upfront in QEMU.
> > 
> > Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
> 
> I presume you're talking about host kernel limitations here?

No, this is a guest kernel limitation. Pls refer to the related discussions
about this here:

https://lkml.org/lkml/2015/6/24/1

> 
> If that does get changed in future we'll need some sort of ugly compat
> test in qemu to see if the new kernel can handle it, but there's no
> way to avoid that, so.

Yeah, I see that.

Regards,
Bharata.

  reply	other threads:[~2015-06-26  5:44 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-25  6:14 [Qemu-devel] [PATCH v5 0/6] Memory hotplug for PowerPC sPAPR guests Bharata B Rao
2015-06-25  6:14 ` [Qemu-devel] [PATCH v5 1/6] spapr: Initialize hotplug memory address space Bharata B Rao
2015-06-26  5:21   ` David Gibson
2015-06-25  6:14 ` [Qemu-devel] [PATCH v5 2/6] spapr: Add LMB DR connectors Bharata B Rao
2015-06-26  5:38   ` David Gibson
2015-06-26  6:54     ` Bharata B Rao
2015-06-25  6:14 ` [Qemu-devel] [PATCH v5 3/6] spapr: Support ibm, dynamic-reconfiguration-memory Bharata B Rao
2015-06-26  5:28   ` David Gibson
2015-06-25  6:14 ` [Qemu-devel] [PATCH v5 4/6] spapr: Make hash table size a factor of maxram_size Bharata B Rao
2015-06-25  6:14 ` [Qemu-devel] [PATCH v5 5/6] spapr: Memory hotplug support Bharata B Rao
2015-06-26  5:31   ` David Gibson
2015-06-25  6:14 ` [Qemu-devel] [RFC PATCH v5 6/6] spapr: Don't allow memory hotplug to memory less nodes Bharata B Rao
2015-06-26  5:33   ` David Gibson
2015-06-26  5:43     ` Bharata B Rao [this message]
2015-06-26  6:06 ` [Qemu-devel] [PATCH v5 0/6] Memory hotplug for PowerPC sPAPR guests David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150626054314.GE5569@in.ibm.com \
    --to=bharata@linux.vnet.ibm.com \
    --cc=agraf@suse.de \
    --cc=aik@ozlabs.ru \
    --cc=david@gibson.dropbear.id.au \
    --cc=imammedo@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=nfont@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=tyreld@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).