From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52244) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z8POW-0003Sk-8N for qemu-devel@nongnu.org; Fri, 26 Jun 2015 04:53:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z8POR-0008VG-8v for qemu-devel@nongnu.org; Fri, 26 Jun 2015 04:53:56 -0400 Date: Fri, 26 Jun 2015 09:53:45 +0100 From: Stefan Hajnoczi Message-ID: <20150626085345.GA15457@stefanha-thinkpad.redhat.com> References: <1432822629-25401-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="rwEMma7ioTxnRzrJ" Content-Disposition: inline In-Reply-To: <1432822629-25401-1-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] blockdev: no need to drain+flush in hmp_drive_del List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, "open list:Block layer core" , armbru@redhat.com --rwEMma7ioTxnRzrJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 28, 2015 at 04:17:09PM +0200, Paolo Bonzini wrote: > bdrv_close already does that, and in fact hmp_drive_del would need > another drain after the flush (which bdrv_close does). So remove > the duplication. >=20 > Signed-off-by: Paolo Bonzini > --- > blockdev.c | 3 --- > 1 file changed, 3 deletions(-) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan --rwEMma7ioTxnRzrJ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVjRMZAAoJEJykq7OBq3PIMOAIAL9xJ6SWSQdyxwhG2x3GSyqO QeJeW0ZGt83qClVqtoDYpTLh5wgpggraRScK2PLieEFTjdMOedHW8mrlqIyarrAv GmDX37j58MnS2N9nM+xPz+wwkusqCzyc1T2C0Q/eMeemm4d+OrYklj5BPfqpzU3h tEjMwjSNSNWd/v6sD2jVEBKCfezBsNN0Cvn6uAOy/fmhnB9xLv8ny1AY86R/R0Tr kn1bwgiiuTkYYec9fhq1Bp3rI8Gw6GzKSLlUE5smF3csVZT3CB2WctdYE0xh6CRH rDPELtv1r0DSUjHJ/l8pqWB5A0E5TgAzsKwL0fY11hknL3qDO+jS65sEUrAJMKM= =BUiF -----END PGP SIGNATURE----- --rwEMma7ioTxnRzrJ--