From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38171) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z8Q9B-00053L-8g for qemu-devel@nongnu.org; Fri, 26 Jun 2015 05:42:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z8Q95-0006ay-Qt for qemu-devel@nongnu.org; Fri, 26 Jun 2015 05:42:09 -0400 Received: from mail-wi0-x22e.google.com ([2a00:1450:400c:c05::22e]:34144) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z8Q95-0006au-Jg for qemu-devel@nongnu.org; Fri, 26 Jun 2015 05:42:03 -0400 Received: by wicnd19 with SMTP id nd19so40273725wic.1 for ; Fri, 26 Jun 2015 02:42:03 -0700 (PDT) Date: Fri, 26 Jun 2015 10:41:59 +0100 From: Stefan Hajnoczi Message-ID: <20150626094159.GF15457@stefanha-thinkpad.redhat.com> References: <1435161381-31521-1-git-send-email-thuth@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="rWhLK7VZz0iBluhq" Content-Disposition: inline In-Reply-To: <1435161381-31521-1-git-send-email-thuth@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/5] Network traffic dumping for -netdev, second try List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: Jason Wang , qemu-devel@nongnu.org, Stefan Hajnoczi , Markus Armbruster --rWhLK7VZz0iBluhq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 24, 2015 at 05:56:16PM +0200, Thomas Huth wrote: > The "-net dump" option only works with the "-net" option. So far, it > is not possible to dump network traffic with the "-netdev" option yet. > This patch series now fixes this ugliness by enabling dumping for the > "-netdev" option, too. >=20 > Unlike with my first attempt a couple of weeks ago ("net: Enable vlans > and dump for -netdev, too"), this patch series now does not "abuse" > the disliked internal vlan hub infrastructure anymore but introduces > a new, clean "dumpfile=3Dxxx" option for the -netdev parameters instead. >=20 > It's likely too late for version 2.4 for this patch series, but it > would be great to get some review feedback for this anyway. >=20 > Thomas Huth (5): > net/dump: Add support for receive_iov function > net/dump: Move DumpState into NetClientState > net/dump: Rework net-dump init functions > net/dump: Add dump option for netdev devices > qemu options: Add information about dumpfile to help text >=20 > include/net/net.h | 8 +++++ > net/clients.h | 5 ++++ > net/dump.c | 89 ++++++++++++++++++++++++++++++++++++-------------= ------ > net/net.c | 48 ++++++++++++++++++++++++++++++ > qapi-schema.json | 12 ++++++-- > qemu-options.hx | 26 +++++++++++----- > 6 files changed, 147 insertions(+), 41 deletions(-) Overall this approach looks good, let's do it in QEMU 2.5. --rWhLK7VZz0iBluhq Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVjR5nAAoJEJykq7OBq3PIaxcIAIgqUPO496sUzZr6HxVGuWSs 0h8/moi0dd7B0LS9BeMw5TzMHwnNNmsLuIWnf7kMBex0oNsgQ8Y83trydK8rqxtm v0p58qYHSv2eTJIqnCGt9s3524D5by2omBwWlayjwMJ7uY+liP/bEwYdarWD01lo p5bRFrs+WZwdyTApYb/AWOmVieltB4UxINWa+G3jUrqBk0TnCIqClYCywuzFcVMg B35fQd6HGQNmMBsENsDtvmz9VjsJxeIfjB4R+n1EEHsIXGIiW7SgOT6yLEMvqHFn mdpLM9S7bTpJ2lf1icWRIYyEl9SV9X+mv93m3LuUc4y+nrOqE2e2iUmTD+zSXp0= =aj9n -----END PGP SIGNATURE----- --rWhLK7VZz0iBluhq--