qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] hostmem: fix build failure caused by qerror cleanups
Date: Fri, 26 Jun 2015 11:36:31 +0200	[thread overview]
Message-ID: <20150626113631.7a9c1b70@nial.brq.redhat.com> (raw)
In-Reply-To: <87zj3mu957.fsf@blackfin.pond.sub.org>

On Fri, 26 Jun 2015 11:11:16 +0200
Markus Armbruster <armbru@redhat.com> wrote:

> Igor Mammedov <imammedo@redhat.com> writes:
> 
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> > ---
> >  backends/hostmem.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/backends/hostmem.c b/backends/hostmem.c
> > index 4b5c53d..403be07 100644
> > --- a/backends/hostmem.c
> > +++ b/backends/hostmem.c
> > @@ -15,6 +15,7 @@
> >  #include "qapi-visit.h"
> >  #include "qemu/config-file.h"
> >  #include "qom/object_interfaces.h"
> > +#include "qapi/qmp/qerror.h"
> >  
> >  #ifdef CONFIG_NUMA
> >  #include <numaif.h>
> > @@ -225,7 +226,7 @@ static void host_memory_backend_set_id(Object *obj, const char *id,
> >      HostMemoryBackend *backend = MEMORY_BACKEND(obj);
> >  
> >      if (backend->id) {
> > -        error_set(errp, QERR_INVALID_PARAMETER_VALUE, "id",
> > +        error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "id",
> >                    "can't change already set value");
> >          return;
> >      }
> 
> I can't see this code in master or on the list.
> 

true, my local tree seems to be in a weird state.
I've just cloned fresh tree and there isn't any error_set left in that file.
I'm sorry for noise.

      reply	other threads:[~2015-06-26  9:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-25 13:48 [Qemu-devel] [PATCH] hostmem: fix build failure caused by qerror cleanups Igor Mammedov
2015-06-26  9:11 ` Markus Armbruster
2015-06-26  9:36   ` Igor Mammedov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150626113631.7a9c1b70@nial.brq.redhat.com \
    --to=imammedo@redhat.com \
    --cc=armbru@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).