From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36057) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z8WEL-0008PH-Nk for qemu-devel@nongnu.org; Fri, 26 Jun 2015 12:11:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z8WEH-0007tg-Nk for qemu-devel@nongnu.org; Fri, 26 Jun 2015 12:11:53 -0400 Date: Fri, 26 Jun 2015 17:11:42 +0100 From: Stefan Hajnoczi Message-ID: <20150626161142.GH31186@stefanha-thinkpad.redhat.com> References: <1435018875-22527-1-git-send-email-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="l06SQqiZYCi8rTKz" Content-Disposition: inline In-Reply-To: <1435018875-22527-1-git-send-email-jsnow@redhat.com> Subject: Re: [Qemu-devel] [PATCH 00/16] ahci: ncq cleanup, part 2 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org --l06SQqiZYCi8rTKz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 22, 2015 at 08:20:59PM -0400, John Snow wrote: > requires: 1434470575-21625-1-git-send-email-jsnow@redhat.com > 1435016308-6150-1-git-send-email-jsnow@redhat.com > [PATCH v2 0/4] ahci: misc fixes/tests for 2.4 > [PATCH v2 00/16] ahci: ncq cleanup, part 1 >=20 > This chunk gets NCQ migration and and resume support working. >=20 > There's still some left to do, particularly around error handling > and FIS semantics, but this should get us most of the way there. >=20 > There is one RFC bit in this patch, inside of Patch #1, concerning > how to handle truncating PRDTs that are too large -- it looks like > we have attempted to address it in the past, and I accidentally > bumped up against it now. By actually trying to consume the PRDs > but ignoring any extra space they describe, I would break ide-test. >=20 > I'll post logs later, but judging by the test text itself, we don't > seem to know what the right behavior is. >=20 > _________________________________________________________________________= _______ >=20 > For convenience, this branch is available at: > https://github.com/jnsnow/qemu.git branch ahci-ncq-s2 > https://github.com/jnsnow/qemu/tree/ahci-ncq-s2 >=20 > This version is tagged ahci-ncq-s2-v1: > https://github.com/jnsnow/qemu/releases/tag/ahci-ncq-s2-v1 >=20 > John Snow (16): > ide: add limit to .prepare_buf() > ahci: stash ncq command > ahci: assert is_ncq for process_ncq > ahci: refactor process_ncq_command > ahci: factor ncq_finish out of ncq_cb > ahci: record ncq failures > ahci: kick NCQ queue > ahci: correct types in NCQTransferState > ahci: correct ncq sector count > qtest/ahci: halted NCQ test > ahci: add cmd header to ncq transfer state > ahci: ncq migration > ahci: add get_cmd_header helper > ahci: Do not map cmd_fis to generate response > qtest/ahci: halted ncq migration test > ahci: fix sdb fis semantics >=20 > hw/ide/ahci.c | 330 ++++++++++++++++++++++++++++++++----------------= ------ > hw/ide/ahci.h | 9 +- > hw/ide/core.c | 12 +- > hw/ide/internal.h | 4 +- > hw/ide/macio.c | 2 +- > hw/ide/pci.c | 5 +- > tests/ahci-test.c | 38 +++++-- > 7 files changed, 252 insertions(+), 148 deletions(-) I posted comments on a few patches. The rest looks good. --l06SQqiZYCi8rTKz Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVjXm+AAoJEJykq7OBq3PIyrIH/iSiYD/1ydjG2y6kXNtSXIWk tojFYP1O6i10RBLC6CMQVUJnz17mhHfxsIkhD4QqS1O99fGRrtiwPilOKp6e0vnr NI/eoqTpigBQrbSsUvqtzUYkwXM5A4kyqBK3Sr2E5j17Mirv+LgCpP84Koyl/Ec3 c9KeDDY6U1/fFuXEoV2CDhLNaZC/Zy+ByDcWwIRfll2FKeY/u2/+ircTHIz6Rw5S qGwUyV7oyA0QfGARIPCfpx3k8yoy8tYNJWLMsmKDyIccmmJnpFuE2g38GKCaS7jo +KelmRqIMQrQKcJOyw0yQBfkE/0rFqoCj9Z42kgTOdqH4LDrpsggpGXzqdBGSi0= =47OO -----END PGP SIGNATURE----- --l06SQqiZYCi8rTKz--