From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51480) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z8X45-0005yE-6M for qemu-devel@nongnu.org; Fri, 26 Jun 2015 13:05:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z8X41-000219-3n for qemu-devel@nongnu.org; Fri, 26 Jun 2015 13:05:21 -0400 Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:53781) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z8X40-0001xV-QC for qemu-devel@nongnu.org; Fri, 26 Jun 2015 13:05:17 -0400 Received: from /spool/local by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 26 Jun 2015 18:05:14 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 76BFA17D8056 for ; Fri, 26 Jun 2015 18:06:22 +0100 (BST) Received: from d06av05.portsmouth.uk.ibm.com (d06av05.portsmouth.uk.ibm.com [9.149.37.229]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t5QH5CwB35192922 for ; Fri, 26 Jun 2015 17:05:13 GMT Received: from d06av05.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av05.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t5QH5ClN023936 for ; Fri, 26 Jun 2015 11:05:12 -0600 Date: Fri, 26 Jun 2015 19:05:07 +0200 From: Greg Kurz Message-ID: <20150626190507.3fb83338@bahia.local> In-Reply-To: <20150626182809-mutt-send-email-mst@redhat.com> References: <20150626073212.26832.5649.stgit@bahia.huguette.org> <20150626073221.26832.58745.stgit@bahia.huguette.org> <20150626122845.566e1786.cornelia.huck@de.ibm.com> <20150626141838.612820ac@bahia.local> <20150626182809-mutt-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] dataplane: drop copy_in_vring_desc() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Cornelia Huck , qemu-devel@nongnu.org, Stefan Hajnoczi On Fri, 26 Jun 2015 18:28:42 +0200 "Michael S. Tsirkin" wrote: > On Fri, Jun 26, 2015 at 02:18:38PM +0200, Greg Kurz wrote: > > On Fri, 26 Jun 2015 12:28:45 +0200 > > Cornelia Huck wrote: > > > > > On Fri, 26 Jun 2015 09:32:21 +0200 > > > Greg Kurz wrote: > > > > > > > During early virtio 1.0 devel, there were several proposals about how to > > > > deal with the endianness of the vring descriptor fields: > > > > - convert the decriptor to host endianness in a single place, and use its > > > > fields directly in the code > > > > - keep the descriptor untouched and use virtio memory helpers to access its > > > > fields with the appropriate endianness > > > > > > > > It seems like both approaches got merged: commit f5a5628cf0b6 introduces > > > > an extra swap that negates the one brought by commit b0e5d90ebc3e. This > > > > breaks boot in SLOF (BE client) when host is ppc64le with the following > > > > QEMU error: > > > > > > > > Failed to map descriptor addr 0x18e2517e00000000 len 268435456 > > > > > > > > A solution could be to revert f5a5628cf0b6, but dropping copy_in_vring_desc() > > > > is equivalent and result in a smaller patch. > > > > > > I'd prefer the revert, as the resulting code is nicer IMHO. > > > > > > > Agreed. It is good to clear the endianness noise out of the real code. :) > > Can you please send v2 that works the way you want it? > Taken from a previous mail by Stefan: "Cornelia already sent "[PATCH] Revert "dataplane: allow virtio-1 devices" to revert f5a5628cf0b. I acked it but the patch is going through Michael Tsirkin." I guess you just have to take Cornelia's patch + Stefan's ack, and patch 2/2 in my series + Cornelia's rb, and we are all set. :) FWIW I tested and it works exactly the same. > > > But your second patch should apply regardless. > > > > > > > Thanks for your feedback. > > > > > > > > > > This patch allows SLOF to boot the OS. > > > > > > > > Signed-off-by: Greg Kurz > > > > --- > > > > hw/virtio/dataplane/vring.c | 14 ++------------ > > > > 1 file changed, 2 insertions(+), 12 deletions(-) >