From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48066) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9Vrj-0001ay-0W for qemu-devel@nongnu.org; Mon, 29 Jun 2015 06:00:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z9Vrc-0005iX-U6 for qemu-devel@nongnu.org; Mon, 29 Jun 2015 06:00:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42708) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9Vmm-00040G-O1 for qemu-devel@nongnu.org; Mon, 29 Jun 2015 05:55:32 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 5160F91764 for ; Mon, 29 Jun 2015 09:55:32 +0000 (UTC) Date: Mon, 29 Jun 2015 11:55:29 +0200 From: "Michael S. Tsirkin" Message-ID: <20150629115438-mutt-send-email-mst@redhat.com> References: <1435239307-13369-1-git-send-email-lersek@redhat.com> <1435239307-13369-3-git-send-email-lersek@redhat.com> <87ioaa24uc.fsf@blackfin.pond.sub.org> <558D44C6.4070807@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <558D44C6.4070807@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 2/3] hw/i386/pc: reflect any FDC @ ioport 0x3f0 in the CMOS List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: John Snow , Paolo Bonzini , Jan Tomko , Markus Armbruster , qemu-devel@nongnu.org On Fri, Jun 26, 2015 at 02:25:42PM +0200, Laszlo Ersek wrote: > On 06/26/15 11:31, Markus Armbruster wrote: > > Laszlo Ersek writes: > > > >> With the pc-q35-2.4 machine type, if the user creates an ISA FDC manually: > >> > >> -device isa-fdc,driveA=drive-fdc0-0-0 \ > >> -drive file=...,if=none,id=drive-fdc0-0-0,format=raw > >> > >> then the board-default FDC will be skipped, and only the explicitly > >> requested FDC will exist. qtree-wise, this is correct; however such an FDC > >> is currently not registered in the CMOS, because that code is only reached > >> for the board-default FDC. > >> > >> The pc_cmos_init_late() one-shot reset handler -- one-shot because the > >> CMOS is not reprogrammed during warm reset -- should search for any ISA > >> FDC devices, created implicitly (by board code) or explicitly, and set the > >> CMOS accordingly to the ISA FDC(s) with iobase=0x3f0: > >> > >> - if there is no such FDC, report both drives absent, > >> - if there is exactly one such FDC, report its drives in the CMOS, > >> - if there are more than one such FDCs, then pick one (it is not specified > >> which one), and print a warning about the ambiguity. > >> > >> Cc: Jan Tomko > >> Cc: John Snow > >> Cc: Markus Armbruster > >> Cc: Paolo Bonzini > >> Reported-by: Jan Tomko > >> Suggested-by: Markus Armbruster > >> Signed-off-by: Laszlo Ersek > >> Reviewed-by: John Snow > > > > Reviewed-by: Markus Armbruster > > Thank you. Can you or John please send a PULL req for this? (Or include > it in an upcoming PULL of yours.) > > I've been Cc'ing Paolo because the get-maintainer script reported him at > the top for the patch set, but I believe he might not have time for this > now. > > Thanks! > Laszlo It's listed as part of PC in MAINTAINERS, but looks like get-maintainer didn't recognize the format. I fixed it up, will review and queue the patches. -- MST