From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58141) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9ZzT-000689-GI for qemu-devel@nongnu.org; Mon, 29 Jun 2015 10:24:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z9ZzO-0000wR-HZ for qemu-devel@nongnu.org; Mon, 29 Jun 2015 10:24:55 -0400 Date: Mon, 29 Jun 2015 15:24:46 +0100 From: Stefan Hajnoczi Message-ID: <20150629142446.GH32151@stefanha-thinkpad.redhat.com> References: <1435018875-22527-1-git-send-email-jsnow@redhat.com> <1435018875-22527-7-git-send-email-jsnow@redhat.com> <20150626153514.GC31186@stefanha-thinkpad.redhat.com> <558D999B.9090001@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="lrvsYIebpInmECXG" Content-Disposition: inline In-Reply-To: <558D999B.9090001@redhat.com> Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 06/16] ahci: record ncq failures List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org, Stefan Hajnoczi --lrvsYIebpInmECXG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 26, 2015 at 02:27:39PM -0400, John Snow wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 >=20 >=20 >=20 > On 06/26/2015 11:35 AM, Stefan Hajnoczi wrote: > > On Mon, Jun 22, 2015 at 08:21:05PM -0400, John Snow wrote: > >> Handle NCQ failures for cases where we want to halt the VM on IO > >> errors. > >>=20 > >> Signed-off-by: John Snow --- hw/ide/ahci.c > >> | 17 +++++++++++++++-- hw/ide/ahci.h | 1 + hw/ide/internal.h > >> | 1 + 3 files changed, 17 insertions(+), 2 deletions(-) > >>=20 > >> diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 71b5085..a838317 > >> 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -959,13 +959,25 > >> @@ static void ncq_cb(void *opaque, int ret) return; } > >>=20 > >> + ncq_tfs->halt =3D false; > >=20 > > Why does halt need to be cleared here? > >=20 >=20 > Might make more sense to clear it just on the beginning of every > command, in execute(). >=20 > There's no strong reason here other than "If there's an error and it > should be set, it'll get reset again pretty soon." It's just a default > state. >=20 > I could move it from process to execute. By the way, does ->halt need to be cleared in ahci_reset_port()? I'm thinking of a scenario where requests have failed and the port is reset. We should not try to reissue those commands after reset. --lrvsYIebpInmECXG Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVkVUuAAoJEJykq7OBq3PImRkIAJMlKGagTLBnei7n10UVzft8 A4g6xGcOSqh7XYlnvGWu9tCsZoGEOngRLnjEnm3ckdvQF2KKPO9GNZ6yFLJqw4pb WLCYf5Q59wTau0gb90k2/1KL+irWdMFUn5Xj8UnsYyPtY6IXACnlXJ8h7uaQBlJF D5w3VjSLQ8YDpujdtXRudtpNIqFYY7FaNZJcavPYqASYtoLvSSl7Hfzj95xDwBln ZaHUYeP6lrBLClOUNsVO6+IP2Lc225f4vrAFNM3Nw6P+zC72HqdDUXEDgiTcw2QF LXcAN2+cgwGfDP4YGVal1mvEejtxU8mMgPqK4d4hsScxCL95ZX3p8f+reoH1rmU= =VSsB -----END PGP SIGNATURE----- --lrvsYIebpInmECXG--