From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53313) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9jkC-0007wC-I4 for qemu-devel@nongnu.org; Mon, 29 Jun 2015 20:49:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z9jkA-0006rk-Sh for qemu-devel@nongnu.org; Mon, 29 Jun 2015 20:49:48 -0400 Date: Tue, 30 Jun 2015 09:11:41 +1000 From: David Gibson Message-ID: <20150629231141.GA3416@voom.redhat.com> References: <1435556214-2916-5-git-send-email-david@gibson.dropbear.id.au> <5590F958.9020306@redhat.com> <20150629113037.64f0d08f@thh440s> <5591152B.7090200@redhat.com> <559115FC.3090805@redhat.com> <559118B5.4060306@suse.de> <55911C53.9070001@redhat.com> <55911F9A.4040208@suse.de> <55912166.6030504@suse.de> <559125DA.7030603@suse.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="rwEMma7ioTxnRzrJ" Content-Disposition: inline In-Reply-To: <559125DA.7030603@suse.de> Subject: Re: [Qemu-devel] [PATCH 4/4] Disable "info irq" and "info pic" for target-ppc List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Laurent Vivier , Thomas Huth , armbru@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, qemu-ppc@nongnu.org, Andreas =?iso-8859-1?Q?F=E4rber?= --rwEMma7ioTxnRzrJ Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 29, 2015 at 01:02:50PM +0200, Alexander Graf wrote: > On 06/29/15 12:43, Andreas F=E4rber wrote: > >Am 29.06.2015 um 12:36 schrieb Andreas F=E4rber: > >>Am 29.06.2015 um 12:22 schrieb Laurent Vivier: > >>>On 29/06/2015 12:06, Andreas F=E4rber wrote: > >>>>Am 29.06.2015 um 11:55 schrieb Laurent Vivier: > >>>>>On 29/06/2015 11:51, Laurent Vivier wrote: > >>>>>>On 29/06/2015 11:30, Thomas Huth wrote: > >>>>>>>On Mon, 29 Jun 2015 09:52:56 +0200 > >>>>>>>Laurent Vivier wrote: > >>>>>>>>On 29/06/2015 07:36, David Gibson wrote: > >>>>>>>>>diff --git a/monitor.c b/monitor.c > >>>>>>>>>index aeea2b5..8c56bfa 100644 > >>>>>>>>>--- a/monitor.c > >>>>>>>>>+++ b/monitor.c > >>>>>>>>>@@ -2573,7 +2573,7 @@ static mon_cmd_t info_cmds[] =3D { > >>>>>>>>> .help =3D "show the command line history", > >>>>>>>>> .mhandler.cmd =3D hmp_info_history, > >>>>>>>>> }, > >>>>>>>>>-#if defined(TARGET_I386) || defined(TARGET_PPC) || defined(TARG= ET_MIPS) || \ > >>>>>>>>>+#if defined(TARGET_I386) || defined(TARGET_MIPS) || \ > >>>>>>>>> defined(TARGET_LM32) || (defined(TARGET_SPARC) && !defined= (TARGET_SPARC64)) > >>>>>>>>> { > >>>>>>>>> .name =3D "irq", > >>>>>>>>> > >>>>>>>>Perhaps we can a use a "#if defined(CONFIG_I8259) || > >>>>>>>>defined(CONFIG_LM32) || (defined(TARGE_SPARC) && > >>>>>>>>!defined(TARGET_SPARC64))" instead, so we keep the command for PR= eP ? > >>>>>>>AFAIK this currently won't work since CONFIG_I8259 is only defined= for > >>>>>>>the Makefiles, but not for the C pre-processor :-( > >>>>>>Yes, I see that afterward, but ... > >>>>>> > >>>>>>>So unless somebody fixes that first, I think David's approach is t= he > >>>>>>>only practicable solution right now. > >>>>>>if you add "config-devices.h" in GENERATED_HEADERS in Makefile.targ= et, > >>>>>>and include "config-devices.h" in monitor.c, it works (all PREP > >>>>>>dependencies in default-configs/ppc64-softmmu.mak must be removed t= oo) > >>>>>> > >>>>>>But does this change acceptable for a tiny improvement ? > >>>>>In fine, I think we can also do like for sparc: > >>>>> > >>>>>defined(TARGET_PPC) && !defined(TARGET_PPC64) > >>>>Alex specifically requested PReP to be made available in ppc64, too. > >>>Thank you Andreas. > >>> > >>>But why ? (I didn't find the answer with google, a link can be helpful= ). > >http://git.qemu-project.org/?p=3Dqemu.git;a=3Dcommit;h=3Dacbb090b2400f62= 7a801074c4e3e006c7501bb26 > > > >(found by looking at the ppc64-softmmu.mak Git history) > > > >Judging by Markus as the reporter, I assume it was a tree-wide analysis > >that came up with this inconsistency, which I was then asked to fix this > >way. >=20 > Yes, it's consistency. All 64bit targets allow to run their 32bit machine > types as well. Whether this is a sensible thing to do or not is a differe= nt > discussion that (if we want to) we need to do outside of the scope of this > mail thread. >=20 > As far as this patch goes, you get a clear nack from me, as it's a > regression for the prep target. Please just QOM'ify the interrupt "just"!?! > controller, add an interfact that allows you to query the irq stats and t= hen > loop through all devices searching for that interface in the object tree. > That way we should be able to get rid of all #ifdefs in that particular c= ode > and enable new irq controllers to expose their stats easily. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --rwEMma7ioTxnRzrJ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVkdCtAAoJEGw4ysog2bOSnngP/12n2n81hNGBkJjLB13LBota xnvd3YU1MDU4hlLPcMUdBVkRTWlAIbupMF2mfUxADHdgE+GixvM4J0FRkY/CiN9h zKcvqMjNB+N/R0VhGtBSbLGXKaFp+ktzSIszW6q2hOxLCNmIlG1DgOApLSkkVFCq WEybL9nr/AcIKXZQhD2LkiYUUPa6KAcLuyve+M9jvYuEBNcZF2APRPr3gPmHjFYg QMuEmaZDGRwO8EP8cjWjORL+yGoRaREnFGVb7U4oiiKeXAD/OmUpPfFv7OG89HYp 6itb2xOe8va8wtVNvtgaPawB9UdxhJA4oYfsfrq37ffFNlNamV99+bInbjpHwWrR hvp4Flo0MMKTbgpSv9Oql/FmVwmLTkKc6g/BSxoeeJ8H58q2ohrM6t7M/720uDf8 KkzEISd9U6dk1qZRt+ki7qhBGCeI9uamsjONntHrcdrzwyYNQn5oZKk1N1QJ0/cW fAWLqZSED9aAN5n8SQT7YRmRgei8XTTUQ6C50UFPpdej/XxRo33Cean1mIJGnffo jVWXq/iqjK57ToiBJvT2zpCGGfZ5f3O2EGG77R2bZoo+1cROc4ve04HJs2lcWo/b A2uEJjnsdAfJwAD1kC4uRk2niCPDUj8x6T+a5SXPZqcP83kUXgZtVg/33RSTjOR6 79DGu9JCm8fD8hP3y5u0 =iVow -----END PGP SIGNATURE----- --rwEMma7ioTxnRzrJ--