From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43121) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9lnk-0002cG-DH for qemu-devel@nongnu.org; Mon, 29 Jun 2015 23:01:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z9lnf-0001Jo-AY for qemu-devel@nongnu.org; Mon, 29 Jun 2015 23:01:36 -0400 Received: from ozlabs.org ([2401:3900:2:1::2]:39601) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9lne-0001J2-W3 for qemu-devel@nongnu.org; Mon, 29 Jun 2015 23:01:31 -0400 Date: Tue, 30 Jun 2015 12:53:18 +1000 From: David Gibson Message-ID: <20150630025318.GA21587@voom.redhat.com> References: <1435566027-17061-1-git-send-email-bharata@linux.vnet.ibm.com> <1435566027-17061-3-git-send-email-bharata@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="fUYQa+Pmc3FrFX/N" Content-Disposition: inline In-Reply-To: <1435566027-17061-3-git-send-email-bharata@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v4 2/6] pc, pc-dimm: Factor out reusable parts in pc_dimm_plug to a separate routine List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bharata B Rao Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, ehabkost@redhat.com, imammedo@redhat.com --fUYQa+Pmc3FrFX/N Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 29, 2015 at 01:50:23PM +0530, Bharata B Rao wrote: > pc_dimm_plug() has code that will be needed for memory plug handlers > in other archs too. Extract code from pc_dimm_plug() into a generic > routine pc_dimm_memory_plug() that resides in pc-dimm.c. Also > correspondingly refactor re-usable unplug code into pc_dimm_memory_unplug= (). >=20 > Signed-off-by: Bharata B Rao Reviewed-by: David Gibson --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --fUYQa+Pmc3FrFX/N Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVkgSeAAoJEGw4ysog2bOS0swP/3OPbW07ZOntFJ+X9K8P2pmB g0kx4EAvY7je7b2ljMvvOWsA+rCaUyAZBGPOwQLzqny/a0jzPmS9xUVWrt9NOmMW L4iBrbiDtMMdA18UMubu0EEddJ1guiH3wDQaDiy/w2OJnAI4TEsApl+la58s7NPN dq6RY3R6cN30eC6ztqrAJJJ+PInFSBc4gQ+y5yYCT6eNN53mj/23iF+RB8uEIZ7H VuH4QYgGeEj873KlP7c6CTpjNgibSUv4521Pq9wqIpxMHCaFs+YveUpKkWnIqR+X a57fr8cxXIgBSTn7UkUSknfxUo7fAztivi3fyWi7Yl4a1RJ6eeuvsorqf8c2D/Cf +2ayKc3S4xYLEZSIK1DHVs1d+anhs4ZOBTiR7XMLkjoOOyQJ6mB+kUzMI+Ch8MZk 7H46uHzHHfb2YSgBpMCCCESw7WJxVgihWw2dsigphOFfy52i13enQrEqYRld5D2w L8Cpms+5Fz04u8vihvp7iuliGwAD9xSAzWuWJW8E4+4W6m7VUVJ1+K5jbbkpNjRk A+zSksjijbRvlFayHs5ljKgYOuh0w4F9TnznwEHhnG83TNz/6piheu5UW7ZmLNqt W8P962VrtKCw//dZEX2TWBWKqH7RcEvx/5jYELywa8vSmSNVck5pCe00CkaF+UmD hd0z2HrXXAZAxfQaS09W =4AIH -----END PGP SIGNATURE----- --fUYQa+Pmc3FrFX/N--