From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39446) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9myC-00084x-JE for qemu-devel@nongnu.org; Tue, 30 Jun 2015 00:16:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z9my9-0005iI-Dz for qemu-devel@nongnu.org; Tue, 30 Jun 2015 00:16:28 -0400 Date: Tue, 30 Jun 2015 13:38:13 +1000 From: David Gibson Message-ID: <20150630033813.GF26353@voom.redhat.com> References: <1435556214-2916-1-git-send-email-david@gibson.dropbear.id.au> <1435556214-2916-2-git-send-email-david@gibson.dropbear.id.au> <559119F1.2020507@suse.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="HCdXmnRlPgeNBad2" Content-Disposition: inline In-Reply-To: <559119F1.2020507@suse.de> Subject: Re: [Qemu-devel] [PATCH 1/4] Split serial-isa into its own config option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: lvivier@redhat.com, Peter Maydell , thuth@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, Anthony Green , agraf@suse.de, lcapitulino@redhat.com, qemu-ppc@nongnu.org --HCdXmnRlPgeNBad2 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 29, 2015 at 12:12:01PM +0200, Andreas F=E4rber wrote: > Am 29.06.2015 um 07:36 schrieb David Gibson: > > At present, the core device model code for 8250-like serial ports > > (serial.c) and the code for serial ports attached to ISA-style legacy IO > > (serial-isa.c) are both controlled by the CONFIG_SERIAL variable. > >=20 > > There are lots and lots of embedded platforms that have 8250-like serial > > ports but have never had anything resembling ISA legacy IO. Therefore, > > split serial-isa into its own CONFIG_SERIAL_ISA option so it can be > > disabled for platforms where it's not appropriate. > >=20 > > For now, I enabled CONFIG_SERIAL_ISA in every default-config where > > CONFIG_SERIAL is enabled, excepting microblaze, xtensa and or32. Those > > platforms have technically lost functionality, but since they have no > > other PCI or ISA devices, it's fairly clear they never actually used > > leagacy IO stuff. >=20 > I think we can add moxie to that list, I'd be very surprised if it uses > ISA. Applies also to 2/4. CC'ing the maintainer. Right. I'm being deliberately conservative in what I removed here. With this patch in place it's easy for boards to remove ISA serial support in future, but that seems like a change best made by the people who actually know the boards. > Which arm machines use ISA? I don't know, but the point was I couldn't quickly convince myself that none did. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --HCdXmnRlPgeNBad2 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVkg8lAAoJEGw4ysog2bOS79MQALI9ztBcSxAKI+05cNTUFZm0 7hwOh9pDRmeug2NNq1ZYMZA7sVdlP+8+eNs4kFwUJW2T0+cbCPqtniB8rJ3TWCwk MI4z7XAdI+sDyVr8xVsOhP/fYQ0KY+LlrLseX7BtuugvABOv9YLqpWTuyWjO/u9p 0nWCAr6x0E1lWYVhsUXbVnPneirjkiLaSF0vMhhG6fgyQWK5Uqip+M/e9tlT9nBs FFhbbAsYeKUtu8Claaq6EJBEvCXEpeW91Um/WeSwl0u9/KKHDDFpwczAm+I8iF4G bt1RBfXqQ2ze9oo5XZRXCBwp+sI00o+Vv7mtOXICxu60rUku7F2fgPoobE7TVZsT G3UEtxxgKXkwCnCKEKesfidntu2F6/m28fXN9BCI6xR7O0cY0C2bmUZ8w1FnPFQA mvxoSKpvznNaAXj6inWYbaLTqYJaSRntdmvcl2Rwyhw+aJt9rUJndaZLqoCGtYli VEsLkjO7KAz7yWsgxdvVS9zXzfbvBj57GLerFdVZ+9U8vApxcd/mjT2Weds0qc9d 4iYFZErh7HTJwexzBZjxw/SX6EaoXRKgmS5fjvSjBNEOhEtG1KoXCoMFYNJJLwgv MD6E57/Z0q6qy4p73D03MTOExP5lOGmfvaRU9KYSmTySB6vYZvM6DjUB1bFk7+8y 1TS9hdXfD9/Zrx2cEovG =KOs/ -----END PGP SIGNATURE----- --HCdXmnRlPgeNBad2--