From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39439) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9myB-00084t-SK for qemu-devel@nongnu.org; Tue, 30 Jun 2015 00:16:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z9my9-0005iN-E2 for qemu-devel@nongnu.org; Tue, 30 Jun 2015 00:16:27 -0400 Date: Tue, 30 Jun 2015 13:40:20 +1000 From: David Gibson Message-ID: <20150630034020.GG26353@voom.redhat.com> References: <1435556214-2916-1-git-send-email-david@gibson.dropbear.id.au> <1435556214-2916-2-git-send-email-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="nqkreNcslJAfgyzk" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH 1/4] Split serial-isa into its own config option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: lvivier@redhat.com, Alexander Graf , Thomas Huth , Markus Armbruster , QEMU Developers , Luiz Capitulino , "qemu-ppc@nongnu.org" , Andreas =?iso-8859-1?Q?F=E4rber?= --nqkreNcslJAfgyzk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 29, 2015 at 11:35:23AM +0100, Peter Maydell wrote: > On 29 June 2015 at 06:36, David Gibson wrot= e: > > At present, the core device model code for 8250-like serial ports > > (serial.c) and the code for serial ports attached to ISA-style legacy IO > > (serial-isa.c) are both controlled by the CONFIG_SERIAL variable. > > > > There are lots and lots of embedded platforms that have 8250-like serial > > ports but have never had anything resembling ISA legacy IO. Therefore, > > split serial-isa into its own CONFIG_SERIAL_ISA option so it can be > > disabled for platforms where it's not appropriate. > > > > For now, I enabled CONFIG_SERIAL_ISA in every default-config where > > CONFIG_SERIAL is enabled, excepting microblaze, xtensa and or32. Those > > platforms have technically lost functionality, but since they have no > > other PCI or ISA devices, it's fairly clear they never actually used > > leagacy IO stuff. >=20 > s/leagacy/legacy/ >=20 > Is it worth having a default-configs/isa.mak along the > lines of our current pci.mak and usb.mak, for putting > CONFIG_ defines for all ISA devices? I considered it, but there were enough variations in exactly what ISA options were selected in the existing configs for different targets that it seemed like a substantial distraction from what I'm trying to accomplish. > A quick grep suggests you can knock arm, moxie, sh4 > and sh4eb off your list of things with CONFIG_SERIAL_ISA > (no hits for ISABus). >=20 > I notice in passing that we still have a handful of config > files which set CONFIG_ISA_MMIO, despite that having been > deleted in commit 61fcb628627ea4 two years ago. >=20 > thanks > -- PMM >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --nqkreNcslJAfgyzk Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVkg+kAAoJEGw4ysog2bOSqUAP/2oF9h9BZbhMYkx2QGRjQS3Q 3aAClI4niMAOA1zhQv82IZ4ki+2lHxvox9faZmF1T0/LUFEeGE/1h3MwJLg5d5mH 1LAAk7i0Jm8w8bgH+ig1sO8dVXLIzRIEMSeH1jMb2/jrknKIBYY7SCkWqIpitr4K pJUqDkypGCAwZS8r58zCrFacJuhfr0ZuPJxXCrK32Q77rx2LgoXTImP/Q4Y+XiDs 08D+dtzjPBBTdgdW9HzcAl+sO1wln5aLIZsGqkzkbPqmN5bQ6JF+whaupKDpBUGc 2ucEqFsnXwL82XT/V1StyPLkyP6u499JqKu04DS8Sm18sPQnH7hxFm+6xOnYg8i7 gs/QqVo/82Zd4QZL5eHY5H/hsnl2uOlxsrJcN3/jqNPg0BZqOSaq61CqXQJVI/6Y UpOoxJSZ5FllrAXRupzDcQ6h7fk9p1A7CsTFL6D8rGdzHNW6VK28X3YrlaIfPGKZ EvzDjtAX1XywuJfrn1YoGrcbNE1fvc5MQpPsxq5uUhhE5ObVaEvb5rZQNzN5KrJ1 s37JhSP68QTAlEwPIxceAGMT2r4qBXd4hV3//GtwgLUy0uIq/dOhvn7Q/DpdiXP+ vxG3f++uqxtuTeR2D0BMvJ97OjtCFKSFIeLbhHMswbLPOWHIsuMLJC3PZoC9XDxr dMhxybfPeUZACbLeNw7e =gm9i -----END PGP SIGNATURE----- --nqkreNcslJAfgyzk--