From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39445) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9myC-00084w-J4 for qemu-devel@nongnu.org; Tue, 30 Jun 2015 00:16:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z9my9-0005iB-Dx for qemu-devel@nongnu.org; Tue, 30 Jun 2015 00:16:28 -0400 Date: Tue, 30 Jun 2015 13:44:10 +1000 From: David Gibson Message-ID: <20150630034410.GH26353@voom.redhat.com> References: <1435556214-2916-1-git-send-email-david@gibson.dropbear.id.au> <1435556214-2916-3-git-send-email-david@gibson.dropbear.id.au> <55911D6A.7000800@suse.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="JI+G0+mN8WmwPnOn" Content-Disposition: inline In-Reply-To: <55911D6A.7000800@suse.de> Subject: Re: [Qemu-devel] [PATCH 2/4] Allow ISA bus to be configured out List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: lvivier@redhat.com, agraf@suse.de, thuth@redhat.com, armbru@redhat.com, Anthony Green , qemu-devel@nongnu.org, lcapitulino@redhat.com, qemu-ppc@nongnu.org, Paolo Bonzini , Guan Xuetao --JI+G0+mN8WmwPnOn Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 29, 2015 at 12:26:50PM +0200, Andreas F=E4rber wrote: > Am 29.06.2015 um 07:36 schrieb David Gibson: > > Currently, the code to handle the legacy ISA bus is always included in > > qemu. However there are lots of platforms that don't include ISA legacy > > devies, and quite a few that have never used ISA legacy devices at all. > >=20 > > This patch allows the ISA bus code to be disabled in the configuration = for > > platforms where it doesn't make sense. For now, the default configs are > > adjusted to include ISA on all platforms including PCI (since > > CONFIG_IDE_CORE which is in pci.mak requires ISA support) and also seve= ral > > others which include ISA devices. We may want to pare this down in fut= ure. >=20 > PCI also allows to have a PCI-ISA bridge such as the i82378, which means > that all PCI platforms can potentially obtain an actual ISA bus. So at > least the commit message could use a makeover to avoid someone touching > IDE to blindly disable the dependency. Sorry, I'm not quite following what you're getting at here. > You'd also need to think about the qtests then: >=20 > $ git grep i82378 -- tests/ > tests/endianness-test.c: { "ppc", "g3beige", 0xfe000000, .bswap =3D > true, .superio =3D "i82378" }, > tests/endianness-test.c: { "ppc", "bamboo", 0xe8000000, .bswap =3D > true, .superio =3D "i82378" }, > tests/endianness-test.c: { "ppc64", "mac99", 0xf2000000, .bswap =3D > true, .superio =3D "i82378" }, > tests/endianness-test.c: .bswap =3D true, .superio =3D "i82378" }, > tests/endianness-test.c: { "sh4", "r2d", 0xfe240000, .superio =3D > "i82378" }, > tests/endianness-test.c: { "sh4eb", "r2d", 0xfe240000, .bswap =3D true, > .superio =3D "i82378" }, Ah, good point. I'll need to rework for that, --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --JI+G0+mN8WmwPnOn Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVkhCKAAoJEGw4ysog2bOSmfkP/2mBrFtR6INFniyYBNSZpri1 SbAP3H/GiXLQBJPRADNmE+Z0V3qoPuHclBV5pA1z4rleM/TMj9DxlNqIm9MDGtZb rkGtVhjANBwy+Ig7QJzxG6+ilXA+XXTSfL6aq2W+MO8FJOwQN3kty2aZOc1j8fwG axJBAN6USAjlX2ZyTUbSQVJVy8fjmVTaz7e484bNYZdxKcxHNj6yxSOpIWvJCTiS UqDXPEEcDeskHQNhUkQStm7bZC/3D3Rze9XrLmTdQAHdUKy70vyRJd9qDLGvBx8V rm2GQJ2qEqwgwYyJuNwSG7WuXTmI3Aa/HB4mCNL18lPHGOwgOXft0J6hlKJ9gcrG A1oRBXhpvzQGc1KlBsJ5MUwuZ0l0QyUNWzbIXf9Pm+ByjU/CRKAyNb4JZsdJecPf 0FpPn7uoaayQLISht0LSaOrd113Mx5G8Xe6mHTxm0/bqD/C4e545ZFdLNj1vwUCf E3agZgY5pFLB4/5gwc99DNZkRtf401Gyux4/Gh9g61rPOFxaL3t/AYZ0H2eom0PJ ARXeNT/qrWOkYVSQXvp6OLbkT+KpRQtaGlI3JFkGkMmyHieXH4R2JLVuMOa+Lrw1 33d/KY3Pj0uLi7JraCnrAjIuFnKw93xNcwKfJo2o92aCsAOXiekx5vrAdYm13qX4 CYq3nzw1rZQMc2vPi8LR =B/Wx -----END PGP SIGNATURE----- --JI+G0+mN8WmwPnOn--