From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46781) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9nSL-0006IU-4O for qemu-devel@nongnu.org; Tue, 30 Jun 2015 00:47:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z9nSG-000417-UC for qemu-devel@nongnu.org; Tue, 30 Jun 2015 00:47:37 -0400 Date: Tue, 30 Jun 2015 14:48:12 +1000 From: David Gibson Message-ID: <20150630044812.GI26353@voom.redhat.com> References: <1435556214-2916-1-git-send-email-david@gibson.dropbear.id.au> <1435556214-2916-3-git-send-email-david@gibson.dropbear.id.au> <55911D6A.7000800@suse.de> <20150630034410.GH26353@voom.redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="TA4f0niHM6tHt3xR" Content-Disposition: inline In-Reply-To: <20150630034410.GH26353@voom.redhat.com> Subject: Re: [Qemu-devel] [PATCH 2/4] Allow ISA bus to be configured out List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: lvivier@redhat.com, agraf@suse.de, thuth@redhat.com, armbru@redhat.com, Anthony Green , qemu-devel@nongnu.org, lcapitulino@redhat.com, qemu-ppc@nongnu.org, Paolo Bonzini , Guan Xuetao --TA4f0niHM6tHt3xR Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 30, 2015 at 01:44:10PM +1000, David Gibson wrote: > On Mon, Jun 29, 2015 at 12:26:50PM +0200, Andreas F=E4rber wrote: > > Am 29.06.2015 um 07:36 schrieb David Gibson: > > > Currently, the code to handle the legacy ISA bus is always included in > > > qemu. However there are lots of platforms that don't include ISA leg= acy > > > devies, and quite a few that have never used ISA legacy devices at al= l. > > >=20 > > > This patch allows the ISA bus code to be disabled in the configuratio= n for > > > platforms where it doesn't make sense. For now, the default configs = are > > > adjusted to include ISA on all platforms including PCI (since > > > CONFIG_IDE_CORE which is in pci.mak requires ISA support) and also se= veral > > > others which include ISA devices. We may want to pare this down in f= uture. > >=20 > > PCI also allows to have a PCI-ISA bridge such as the i82378, which means > > that all PCI platforms can potentially obtain an actual ISA bus. So at > > least the commit message could use a makeover to avoid someone touching > > IDE to blindly disable the dependency. >=20 > Sorry, I'm not quite following what you're getting at here. >=20 > > You'd also need to think about the qtests then: > >=20 > > $ git grep i82378 -- tests/ > > tests/endianness-test.c: { "ppc", "g3beige", 0xfe000000, .bswap =3D > > true, .superio =3D "i82378" }, > > tests/endianness-test.c: { "ppc", "bamboo", 0xe8000000, .bswap =3D > > true, .superio =3D "i82378" }, > > tests/endianness-test.c: { "ppc64", "mac99", 0xf2000000, .bswap =3D > > true, .superio =3D "i82378" }, > > tests/endianness-test.c: .bswap =3D true, .superio =3D "i82378" }, > > tests/endianness-test.c: { "sh4", "r2d", 0xfe240000, .superio =3D > > "i82378" }, > > tests/endianness-test.c: { "sh4eb", "r2d", 0xfe240000, .bswap =3D tr= ue, > > .superio =3D "i82378" }, >=20 > Ah, good point. I'll need to rework for that, Actually.. on second thoughts.. CONFIG_I82378 already exists, and will break those tests of disabled. So while making the tests more robust against config changes would be a good thing in general, I don't think it's in the scope of what I'm trying to do here - making ISA configurable won't make these tests any more broken with nonstandard configs than they already are. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --TA4f0niHM6tHt3xR Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVkh+MAAoJEGw4ysog2bOSVYYQAOPBoIy2HIn2mubgu6yPWep/ Qy6Uvtqrw7rSGFxnpzKJzLuz1C+ZGRSV6Np8o/LjubPpCr03Eiz3V1vr42pzKAF5 rsxgQpVIIlNP6NT6fjuTXo53hurhSPjsc/Pb860uLLjhaPcuSoX12J1msLb4pbvz W4vIlBnvJYgdvhEqrPi7deoBv82HP8eMQy0DWZQmPUY7xap9M/WUGx3mC678RRGK J7GAZvUQH76eOgFC5zuHqAN+3xOsWltrCVljweIM6cABP0jkTBSD9WDbVIOZAEJE G5XikRISQIGh/SEx2gL0MRJXwr1h2v0v1MWUizlyKufxofqjGZklaki7RLFg9LUl fIv4EBbbWuwDeM8wOZs+hFn8xqNB8Hs46nvjIOO5YxDSW+glXgUUi/WsTEJyWays Qy0CtLsSVCJLh8LWBNT0+UBhsmWGaX7kc40lorAaLR504yy8JSz78E1KKGH5n3Cb Kjed7nXlol4WFgtYV9Mdy5N2igtaRPrsoO2Kg4zX8PNvGyPARvM0gvX8q5/iYStl 2T67i4L2L6NVYsZnuJ9+5RfoDvKp+sCnIAZ1GBh656pPyWN3uSzEn+hUHE85DJt0 PXRZRsT5vv2lHLqTGYZlmG2GVZ88cIc8Sqbtk3znG7FhuKf44O6SCOmGrhc7E/G4 mVom51Cf7n2wX3iOAJV9 =cdOg -----END PGP SIGNATURE----- --TA4f0niHM6tHt3xR--