From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59508) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9pre-0007oq-72 for qemu-devel@nongnu.org; Tue, 30 Jun 2015 03:21:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z9pra-0004gC-6L for qemu-devel@nongnu.org; Tue, 30 Jun 2015 03:21:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49732) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9pra-0004g6-1a for qemu-devel@nongnu.org; Tue, 30 Jun 2015 03:21:50 -0400 Date: Tue, 30 Jun 2015 15:21:47 +0800 From: Fam Zheng Message-ID: <20150630072147.GC5599@ad.nay.redhat.com> References: <20150630034055.10614.7558.malonedeb@soybean.canonical.com> <20150630034113.15568.92567.malone@wampee.canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150630034113.15568.92567.malone@wampee.canonical.com> Subject: Re: [Qemu-devel] [Bug 1469946] Re: guest can't get IP when create guest with bridge. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bug 1469946 <1469946@bugs.launchpad.net> Cc: qemu-devel@nongnu.org On Tue, 06/30 03:41, chao zhou wrote: > the first bad commit is > commit a90a7425cf592a3afeff3eaf32f543b83050ee5c > Author: Fam Zheng > Date: Thu Jun 4 14:45:17 2015 +0800 > > tap: Drop tap_can_send > > This callback is called by main loop before polling s->fd, if it returns > false, the fd will not be polled in this iteration. > > This is redundant with checks inside read callback. After this patch, > the data will be sent to peer when it arrives. If the device can't > receive, it will be queued to incoming_queue, and when the device status > changes, this queue will be flushed. > > Signed-off-by: Fam Zheng > Message-id: 1433400324-7358-7-git-send-email-famz@redhat.com > Signed-off-by: Stefan Hajnoczi Could you try this patch? http://lists.nongnu.org/archive/html/qemu-devel/2015-06/msg07377.html Fam