From: Stefan Hajnoczi <stefanha@redhat.com>
To: Alberto Garcia <berto@igalia.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
Alexander Yarygin <yarygin@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] block: remove redundant check before g_slist_find()
Date: Tue, 30 Jun 2015 13:54:29 +0100 [thread overview]
Message-ID: <20150630125429.GA30286@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1435583533-5758-1-git-send-email-berto@igalia.com>
[-- Attachment #1: Type: text/plain, Size: 465 bytes --]
On Mon, Jun 29, 2015 at 04:12:13PM +0300, Alberto Garcia wrote:
> An empty GSList is represented by a NULL pointer, therefore it's a
> perfectly valid argument for g_slist_find() and there's no need to
> make any additional check.
>
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
> block/io.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-06-30 12:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-29 13:12 [Qemu-devel] [PATCH] block: remove redundant check before g_slist_find() Alberto Garcia
2015-06-29 13:32 ` Alexander Yarygin
2015-06-30 12:54 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150630125429.GA30286@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=berto@igalia.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=yarygin@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).